fix: skip templating if check fails #863
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for elaborate-horse-ac1743 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
moshloop
reviewed
Mar 15, 2023
| @@ -29,14 +29,21 @@ func RunChecks(ctx *context.Context) []*pkg.CheckResult { | |||
|
|
|||
| func transformResults(ctx *context.Context, in []*pkg.CheckResult) (out []*pkg.CheckResult) { | |||
| for _, r := range in { | |||
| // If check fails, do not apply transform | |||
| if !r.Pass { | |||
There was a problem hiding this comment.
!pass doesn't necessarily means it failed to connect - it could have failed a threshold, response code/body check etc.
There was a problem hiding this comment.
I went through the checks code and all the errors are raised via .Failf or .ErrorMessage (which calls .Failf inside) all of which sets pass = false.
If not for r.Pass, what should we check against ?
There was a problem hiding this comment.
We can add another field called Error = true that ErrorMessage sets - however we might need to update some of the checks to use ErrorMessage instead of Failf for connection errors
moshloop
requested changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #374