Split model visibility, document where vs orWhere
#200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
askvortsov1
added a commit
to flarum/approval
that referenced
this pull request
Apr 20, 2021
Wrapping all `wheres` in an `orWhere` ensures that there's no conflict. See flarum/framework#2798, flarum/docs#200
luceos
requested changes
May 9, 2021
There was a problem hiding this comment.
Now that I read all this, it's even more obvious how confusing this will be to developers. For 2.x we seriously need to improve the logic behind opening up private discussions; aka wrap each extender into their own orWhere or something.
Anyway good job getting this in print :P
Co-authored-by: Daniël Klabbers <luceos@users.noreply.github.com>
SychO9
approved these changes
May 11, 2021
askvortsov1
added a commit
to flarum/approval
that referenced
this pull request
Mar 11, 2022
Wrapping all `wheres` in an `orWhere` ensures that there's no conflict. See flarum/framework#2798, flarum/docs#200
askvortsov1
added a commit
to flarum/approval
that referenced
this pull request
May 10, 2022
Wrapping all `wheres` in an `orWhere` ensures that there's no conflict. See flarum/framework#2798, flarum/docs#200
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.