Fetch raw config values from secrets #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TymKh
force-pushed
the
feature/full-config-from-secret
branch
from
e9ff284 to
7d61aa0
Compare
TymKh
force-pushed
the
feature/full-config-from-secret
branch
from
7d61aa0 to
e56eabf
Compare
metachris
reviewed
Apr 22, 2025
db.dockerfile
Outdated
| @@ -0,0 +1,5 @@ | |||
| FROM postgres:15 | |||
There was a problem hiding this comment.
there's already such a dockerfile in docker/database/Dockerfile -- can we just use that and not add this?
There was a problem hiding this comment.
metachris
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Simplify configuration process. Fetch json config as is from aws secrets manager.
⛱ Motivation and Context
Previous way was forcing us to struggle with escaping/unescaping a lot
📚 References
✅ I have run these commands
make lintmake testgo mod tidy