Add permit flashtestations tx calls from builder #285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avalonche
force-pushed
the
flashtestations-permit
branch
2 times, most recently
from
397a271 to
ad61301
Compare
avalonche
force-pushed
the
flashtestations-permit
branch
from
ad61301 to
75e520c
Compare
SozinM
reviewed
Oct 4, 2025
|
|
||
| pub trait BuilderTransactions<ExtraCtx: Debug + Default = ()>: Debug { | ||
| fn simulate_builder_txs<Extra: Debug + Default>( | ||
| pub trait BuilderTransactions<ExtraCtx: Debug + Default = (), Extra: Debug + Default = ()> { |
There was a problem hiding this comment.
we can move Extra fields to ExtraCtx :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Add permit function calls so that tee signer don't need funding to do the flashtestation transactions. Adds additional flashtestation tests and improves error handling.
CLI Changes
--flashtestations.use-permitenables the permit contract call and does not attempt to fund the tee key. It would use the builder key and many flags such as --flashtestations.rpc-url, --flashtestations.funding-key will not be needed to support flashtestations✅ I have completed the following steps:
make lintmake test