-
Notifications
You must be signed in to change notification settings - Fork 8
feat: tagged checkpoints #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you for this contribution!
I would just like to change how we handle tag in different checkpoint instances, but else this looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces tagged checkpoint functionality, replacing the previous named barrier system with a more flexible tagging mechanism. The changes allow checkpoints to be tagged with metadata for easier reference and identification in history queries.
- Replaces named barriers with a flexible tagging system on checkpoints
- Adds new methods for querying checkpoint history by tags
- Updates display and debug output to include tag information
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
src/test_utils/step.rs | Updates test utilities to use tagged barriers instead of named barriers |
src/payload/ext/checkpoint.rs | Adds new methods for querying checkpoint history by tags |
src/payload/checkpoint.rs | Implements the core tagging functionality and removes named barrier mutation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if we should allow changing any kind of state on an existing checkpoint.
In my opinion tags (if we chose to go with this design) should be attached during checkpoint creation and remain immutable for the whole duration of checkpoints lifetime and the lifetime of all its clones.
Hm I agree. Lets make checkpoint immutable by nature. Then we could overload apply/barrier with a _with_tag |
Makes sense, I agree.
|
Close #21