Better bidding 2

[dvush]

📝 Summary

Adds a new way to seal blocks to enable it set adjust_finalized_blocks = true in the config.

If set to true blocks will be processed in two steps:

1. block is finalized (root hash, receipts root, etc) is processed
2. finalized blocks is sent to the bidding service
3. When bidding service responds finalized block is adjusted with correct bid value

The advantage is that bidding response becomes faster (it takes around 0.5ms on average to adjust finalized block).

In addition this PR:

• adds blob gas to the BlockSpace structure
• allows only transactions payment as a way to pay a proposer

💡 Motivation and Context

---

✅ I have completed the following steps:

• Run make lint
• Run make test
• Added tests (if applicable)

[Copilot]

Pull Request Overview

This PR implements a new bidding optimization feature called "Better bidding 2" that introduces a pipelined block finalization process to improve bidding response times. The main purpose is to enable blocks to be "prefinalized" first and then have payment transactions adjusted later, reducing the average bidding response time to around 0.5ms.

• Adds a new configuration option adjust_finalized_blocks to enable the pipelined finalization process
• Implements prefinalized block processing where blocks are finalized in two steps: first finalization, then bid value adjustment
• Removes the optional coinbase payment mode and enforces transaction-based payments to validators

Reviewed Changes

Copilot reviewed 38 out of 40 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
docs/CONFIG.md	Updates documentation to remove coinbase_payment configuration option
crates/rbuilder/src/utils/receipts.rs	Adds support for adjusting finalized blocks with caching optimizations
crates/rbuilder/src/building/mod.rs	Removes optional coinbase payments, adds blob gas to BlockSpace, implements prefinalized block adjustment
crates/rbuilder/src/live_builder/block_output/unfinished_block_processing.rs	Completely refactors block processing to support prefinalized blocks with separate threads
crates/rbuilder/src/building/builders/block_building_helper.rs	Adds adjust_finalized_block method and implements prefinalized state management
crates/rbuilder/src/telemetry/metrics/mod.rs	Adds new metric for tracking finalize adjust time

Comments suppressed due to low confidence (2)

crates/rbuilder/src/building/mod.rs:1

• This hardcoded fallback to U256::ONE when the block value is non-zero seems like a magic number that could cause issues. Consider using a named constant or documenting why exactly 1 wei is used as the fallback value for contract compatibility.

use crate::{

crates/rbuilder/src/building/builders/block_building_helper.rs:1

• The magic number 2 should be better documented. Consider adding a comment explaining what these two state changes represent (payment transaction and requests processing) as mentioned in the comment above.

use alloy_primitives::{utils::format_ether, U256};

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

Removing elements from the middle of a Vec using remove(i) is O(n) operation and combined with the loop this becomes O(n²). Consider using a more efficient approach like retain() or collecting indices to remove and processing them in reverse order.

[Copilot]

The validation logic is inverted and confusing. When adjust_finalized_block is true, we expect prefinalize_state to be Some, but the condition checks if they're different. Consider renaming the error or restructuring the logic to make the expected state more clear.

[Copilot]

Pull Request Overview

Copilot reviewed 33 out of 34 changed files in this pull request and generated 6 comments.

Comments suppressed due to low confidence (1)

crates/rbuilder/src/building/order_commit.rs:747

• The field name space_used in TransactionExecutionInfo is inconsistent with the old field name gas_used that was replaced. This breaks the existing API contract and could cause confusion. Consider keeping both fields for backward compatibility or updating all call sites consistently.

        space_used: BlockSpace,

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}