Skip to content

Conversation

dvush
Copy link
Contributor

@dvush dvush commented Sep 28, 2025

πŸ“ Summary

πŸ’‘ Motivation and Context


βœ… I have completed the following steps:

  • Run make lint
  • Run make test
  • Added tests (if applicable)

@Copilot Copilot AI review requested due to automatic review settings September 28, 2025 14:23
@dvush dvush requested a review from ZanCorDX as a code owner September 28, 2025 14:23
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new error message to the list of non-critical simulation errors that should be ignored during MEV boost operations. The change prevents the "no state found for block" error from causing critical failures.

Key Changes

  • Added "no state found for block" to the list of non-critical simulation errors

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

"block is too old, outside validation window", // Generated from time to time from agnostic relay in the end of the slot
"block gas limit mismatch", // Generated from time to time from ultrasounds relay when we ignore the gas limit.
"Proposer MEV Protect is enabled", // Generated by bloxroute since we didn't implement Proposer MEV Protect. On 2025/07/17 this is still not critical (the block is still valid) and it's not clear if it will ever be reason for demotion.
"no state found for block",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment with the context where this is generated?

@Copilot Copilot AI review requested due to automatic review settings October 1, 2025 09:49
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@dvush dvush force-pushed the non-critical-sim-error-2025-09-28 branch from 443b10b to 0a056c2 Compare October 2, 2025 15:16
@dvush dvush merged commit a0073cb into develop Oct 2, 2025
3 checks passed
@dvush dvush deleted the non-critical-sim-error-2025-09-28 branch October 2, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants