Integration Test Improvements #165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
0xOsiris
reviewed
Apr 4, 2025
0xOsiris
reviewed
Apr 4, 2025
0xOsiris
reviewed
Apr 4, 2025
Co-authored-by: 0xOsiris <djosiris@proton.me>
0xKitsune
reviewed
Apr 4, 2025
|
So this with this last commit I've been able to fix all the flakey tests. I successfully rand 50 iterations of |
0xOsiris
reviewed
Apr 4, 2025
| use crate::common::TEST_DATA; | ||
|
|
||
| const NAME: &str = "ghcr.io/paradigmxyz/op-reth"; | ||
| const TAG: &str = "v1.3.4"; |
There was a problem hiding this comment.
Suggested change
| const TAG: &str = "v1.3.4"; | |
| const TAG: &str = "latest"; |
There was a problem hiding this comment.
I think we probably want to intentionally increment the version, no? Otherwise we may have tests failing randomly.
There was a problem hiding this comment.
mmm, I guess I'd prefer to just always stay on latest or nightly, and address things as they come up
0xOsiris
approved these changes
Apr 4, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following improvements:
integrationfeaturecargo nextest