build_torcx_store: get selinux context included in torcx tarballs #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far build_torcx_store has not included any selinux context in the tarball, because it ran without `--selinux` option. Let's add the option to fix that.
dongsupark
pushed a commit
to flatcar/torcx
that referenced
this pull request
Jul 31, 2019
To be able to extract tarballs with selinux contexts, torcx needs to turn on `XattrPrivileged`, because the default `XattrUser` option is able to extract only selinux contexts starts with `user` prefix. See also: flatcar-archive/coreos-overlay#55 flatcar/scripts#16
invidian
approved these changes
Jul 31, 2019
dongsupark
pushed a commit
to flatcar/torcx
that referenced
this pull request
Jul 31, 2019
To be able to extract tarballs with selinux contexts, torcx needs to turn on `XattrPrivileged`, because the default `XattrUser` option is able to extract only selinux contexts starting with `user` prefix. See also: flatcar-archive/coreos-overlay#55 flatcar/scripts#16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far build_torcx_store has not included any selinux context in the tarball, because it ran without
--selinuxoption.Let's add the option to fix that.
This PR should be merged after the PR flatcar-archive/coreos-overlay#55 was merged, and a new Flatcar SDK was released from it.