flathub integration request - Nitrokey App #2081
Conversation
|
Queued test build for com.nitrokey.nitrokey-app. |
|
Started test build 37685 |
|
Build 37685 failed |
|
sorry my fault, did not run validate, now providing appdata through this repository, will be updated inside the application on next release, validate now also working: |
|
bot, build com.nitrokey.nitrokey-app |
|
Queued test build for com.nitrokey.nitrokey-app. |
|
Started test build 37712 |
|
Build 37712 failed |
README.md
Outdated
| @@ -0,0 +1,28 @@ | |||
| # com.nitrokey.nitrokey-app - Nitrokey App Flatpak | |||
There was a problem hiding this comment.
This does not seem needed here.
Makefile
Outdated
| @@ -0,0 +1,9 @@ | |||
| local-install: | |||
There was a problem hiding this comment.
I'm usually against helper Makefiles in Flathub repos but it's up to you.
There was a problem hiding this comment.
inherited from old non-flathub flatpak repo, personal anti-forget-mechanism, removed.
| <screenshots> | ||
| <screenshot type="default"> | ||
| <image>https://raw.githubusercontent.com/Nitrokey/nitrokey-app/master/images/icon/nitrokey-app-icon-128-black.png</image> | ||
| <caption><!-- Describe this screenshot in less than ~10 words --></caption> |
There was a problem hiding this comment.
| <caption><!-- Describe this screenshot in less than ~10 words --></caption> |
There was a problem hiding this comment.
updated with 2 screenshots + captions
com.nitrokey.nitrokey-app.yml
Outdated
| sources: | ||
| - type: file | ||
| path: com.nitrokey.nitrokey-app.appdata.xml | ||
| sha256: c7419a0cad827a1a5af82c8f0e6dfccfececa581fdb67a53bfefb0676b939f9d |
There was a problem hiding this comment.
| sha256: c7419a0cad827a1a5af82c8f0e6dfccfececa581fdb67a53bfefb0676b939f9d |
Local files don't need checksums, it's fine to drop it.
| - --socket=x11 | ||
| - --filesystem=host | ||
| - --device=all | ||
| modules: |
There was a problem hiding this comment.
You should add a global cleanup array to remove unneeded files, something like this is a good starting point:
cleanup:
- "*.a"
- /include
com.nitrokey.nitrokey-app.yml
Outdated
| - --device=all | ||
| modules: | ||
| - name: libusb | ||
| buildsystem: autotools |
There was a problem hiding this comment.
autotools is the default build system and doesn't need to be set explicitly.
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "only-arches": ["x86_64"] | |||
There was a problem hiding this comment.
Any reason to limit it to x86_64?
There was a problem hiding this comment.
as of now because it is not tested extensively
|
thx for the feedback, updated and pushed |
|
bot, build com.nitrokey.nitrokey-app |
|
Queued test build for com.nitrokey.nitrokey-app. |
|
Started test build 37742 |
|
Build 37742 failed |
|
Unfortunately there is no 64x64 icon included inside the latest release, pushed it into this repository. This will be fixed and then removed with our next release. Can I also start the build? bot, build com.nitrokey.nitrokey-app |
|
Queued test build for com.nitrokey.nitrokey-app. |
|
Started test build 37747 |
|
Build 37747 failed |
|
struggling with icon paths, bot, build com.nitrokey.nitrokey-app |
|
Queued test build for com.nitrokey.nitrokey-app. |
|
Started test build 37750 |
|
Build 37750 failed |
|
bot, build com.nitrokey.nitrokey-app |
|
Queued test build for com.nitrokey.nitrokey-app. |
|
Started test build 37753 |
|
Build 37753 successful |
|
finally 😄, some more details:
|
|
/merge |
|
A repository for this has been created: https://github.com/flathub/com.nitrokey.nitrokey-app You will receive an invitation to be a collaborator which will grant you write access to the repository above. The invite can be also viewed here. If you have never maintained an application before, common questions are answered in the app maintenance guide. Thanks! |
Please confirm your submission meets all the criteria
device=allwas included in order to support the wide range of security-keys we are supporting now and in the future