Create org.remmina.Remmina #307

amtlib-dot-dll · 2018-03-19T04:04:04Z

Copied from https://github.com/FreeRDP/Remmina/tree/next/flatpak. I am not the orginal author. I just want to use the flatpak version without compile it by myself 😆

TingPing · 2018-03-19T05:34:02Z

org.remmina.Remmina.json

+    },
+    "command": "remmina",
+    "rename-icon": "remmina",
+    "desktop-file-name-prefix": "(Flatpak) ",


Unnecessary

@amtlib-dot-dll This one =)

amtlib-dot-dll@aecd397 Thank you for notifying 😂

TingPing · 2018-03-19T05:34:20Z

org.remmina.Remmina.json

+        "/share/pkgconfig"
+    ],
+    "finish-args": [
+        "--own-name=org.remmina.Remmina",


TingPing · 2018-03-19T05:34:56Z

org.remmina.Remmina.json

+        /* Appindicator */
+        "--talk-name=org.kde.StatusNotifierWatcher",
+        /* Query GNOME Shell version (to display systray icon if supported) */
+        "--talk-name=org.gnome.Shell",


This is an upstream bug, but this is completely the wrong way to handle this.

I opened an upstream bug, please add it as a comment: https://github.com/FreeRDP/Remmina/issues/1536

TingPing · 2018-03-19T05:35:52Z

org.remmina.Remmina.json

+            "name": "nxproxy",
+            "buildsystem": "simple",
+            "build-commands": [
+                "make CONFIGURE='./configure --prefix=/app'",


I don't know why this is the simple build system.

TingPing · 2018-03-19T05:36:03Z

org.remmina.Remmina.json

+        },
+        {
+            "name": "freerdp",
+            "buildsystem": "cmake",


cmake-ninja

Thank you for your review, by the way, what is the difference between cmake and cmake-ninja? The documentation manual is very unclear about that, and I am not familiar with C so reading the source code gives me no clue 🤔

cmake generates Makefiles, ninja is simply faster than make so when it works use it.

Alright 🤦‍♂️

TingPing · 2018-03-19T05:39:38Z

org.remmina.Remmina.json

+                    "name": "lz4",
+                    "buildsystem": "simple",
+                    "build-commands": [
+                        "make -C lib lib",


No need for simple build system:

{ "subdir": "lib", "no-autogen": true, "make-args": ["PREFIX=/app", "lib"], }

TingPing · 2018-03-19T05:40:01Z

org.remmina.Remmina.json

+        },
+        {
+            "name": "libssh",
+            "buildsystem": "cmake",


cmake-ninja

TingPing · 2018-03-19T05:40:32Z

org.remmina.Remmina.json

+        },
+        {
+            "name": "remmina",
+            "buildsystem": "cmake",


cmake-ninja

TingPing · 2018-03-19T05:40:40Z

org.remmina.Remmina.json

+            "name": "remmina",
+            "buildsystem": "cmake",
+            "config-opts": [
+                "-DCMAKE_INSTALL_LIBDIR:PATH=/app/lib",


This can be removed.

TingPing · 2018-03-19T05:40:50Z

org.remmina.Remmina.json

+        {
+            "name": "remmina",
+            "buildsystem": "cmake",
+            "config-opts": [


-DCMAKE_BUILD_TYPE=Release

nedrichards · 2018-03-19T12:44:01Z

bot, build org.remmina.Remmina

nedrichards · 2018-03-19T13:21:22Z

Builds fail with appdata not available https://flathub.org/builds/#/builders/2/builds/221

larchunix · 2018-03-20T20:09:56Z

@amtlib-dot-dll Thanks for pushing my flatpak manifest here.

I opened a PR on Remmina to fix most of the issues raised by @TingPing (FreeRDP/Remmina#1526).

The error raised by @nedrichards has been fixed upstream by FreeRDP/Remmina@a860ca2.

nedrichards · 2018-03-20T20:48:08Z

@larchunix that's awesome! do you know when the next upstream release that includes that will be?

antenore · 2018-03-20T22:41:42Z

You guys are amazing! Thanks a lot!!!!!!!!

I don't know when we will release a new version, I've just merged these modifications upstream in our main branch (named next)

If you need a release to go ahead, we can do it I think.

What do you think @giox069 ?

amtlib-dot-dll · 2018-03-21T02:09:37Z

@larchunix @antenore @giox069

I have an idea. FreeRDP is well-known, and more famous than Remmina, so if we change the app-id from org.remmina.Remmina to org.freerdp.Remmina, people who use search engines to look for FreeRDP will know about Remmina, especially when they search for FreeRDP in the Flathub directory. What do you think?

I am not a developer of Remmina, so I should ask you first 😄

@larchunix

Thanks for @larchunix

antenore · 2018-03-21T06:12:32Z

Personally I have nothing to objects, I think it's a good idea, moreover we belong to the FreeRDP organisation.

antenore · 2018-03-21T07:14:22Z

Finally I'm not sure anymore. The Remmina dbus id is org.remmina.Remmina and it's better to stay in-line with the dbus name.

As soon as we will endorse flatpak, I'm sure we won't need advertising.

So far flatpack and the flathub community looks amazing :-)

Thanks for supporting us!

nedrichards · 2018-03-21T08:12:13Z

Searching is about the information in your appdata, not the app id. I really wouldn't change that.

…

On Wed, 21 Mar 2018, 07:14 Antenore Gatta, ***@***.***> wrote: Finally I'm not sure anymore. The Remmina dbus id is org.remmina.Remmina and it's better to stay in-line with the dbus name. As soon as we will endorse flatpak, I'm sure we won't need advertising. So far flatpack and the flathub community looks amazing :-) Thanks for supporting us! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#307 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AASeVUBXAv-T9PrsDg5AE2WLTKNsjLEDks5tgf3ZgaJpZM4SvkQ5> .

antenore · 2018-03-21T08:51:47Z

If it doesn't hurt we can change it

amtlib-dot-dll · 2018-03-21T09:00:06Z

Searching may also be something like this flatpak remote-ls flathub | grep -i freerdp @nedrichards

TingPing · 2018-03-21T10:27:18Z

The best app-id is a discussion to have with upstream as that is where these appdata files should go.

EDIT: I realize now @antenore is from upstream.

TingPing · 2018-03-21T10:27:36Z

Searching may also be something like this flatpak remote-ls flathub | grep -i freerdp

Well that is just wrong: flatpak search freerdp.

nedrichards · 2018-03-21T11:40:28Z

bot, build org.remmina.Remmina

antenore · 2018-03-22T07:49:40Z

@nedrichards
To resume..

Do you need other changes from our side?
Do you need an official release?

Thanks

nedrichards · 2018-03-22T11:18:26Z

@antenore a release is always helpful, but so long as this is all merged upstream you can attach a patch here since it's not a functional change or user visible bug fix. I don't want to cause you extra work that's unnecessary.

antenore · 2018-03-22T11:23:40Z

Thanks @nedrichards we are preparing a new release, but I don't know exactly when will be available.
I'm waiting with impatience to see Remmina in Flathub, so whatever you need I'm available without any issues.

amtlib-dot-dll · 2018-03-30T11:26:15Z

Any more news guys? 😀 :

nedrichards · 2018-04-01T06:55:31Z

I thought we were waiting for an upstream release or for the changes accepted upstream to be added as a patch to this version (until the next release comes out)

antenore · 2018-04-01T09:27:49Z

@nedrichards we prefer to don't release right now as we are still working hard for the next one.

It's not clear for me, sorry, what I'm supposed to do to accept the patches.
As soon as you'll tell me I'll do what is needed.
Thanks!

nedrichards · 2018-04-02T16:32:19Z

Here's an example of what I mean by a patch. https://github.com/flathub/org.pitivi.Pitivi/blob/master/org.pitivi.Pitivi.json#L138

Flatpak-builder can apply patch files to the source code it uses for each module. You can take the upstream commits, save them as patch files and use this sort of syntax to apply and test them.

antenore · 2018-04-02T20:33:54Z

@nedrichards I'd like to just propose our json file (from upstream) as the one to use for the flathub builds

https://github.com/FreeRDP/Remmina/blob/next/flatpak/org.remmina.Remmina.json

As I don't have rights to modify this PR I can only submit a new one or attach a patch file of the json file.

Regarding the commit to use (https://github.com/FreeRDP/Remmina/blob/next/flatpak/org.remmina.Remmina.json#L481), in our json file we use directly the main branch (named 'next').

The alternatives are to use the releases, or specific commits as @amtlib-dot-dll has done in this PR.

Our (as mainstream devs) preferred choice would be to use 'next'. We do a lo of testing before to push the code in there... Moreover @larchunix recently has fixed some small annoyances.

If you want I can just submit a new PR with the updated flatpak based on your input, but I need to know exactly what you prefer.

In the (near) future, we will submit PRs to improve it further also based on the @TingPing feedback.

Thanks!

amtlib-dot-dll · 2018-04-03T05:04:45Z

@antenore Hi, I sent you an invitation so you can modify this PR via this branch, however I remembered that according to App Requirements · flathub/flathub Wiki

Manifests should therefore refer to tarballs or git tags and not the tip of a branch.

I am afraid that merely the main branch won't be accepted

antenore · 2018-04-03T07:06:12Z

@amtlib-dot-dll thanks! We're discussing internally to do a new release

barthalion · 2018-04-03T09:07:54Z

Some specific commit will also be fine as long as you are willing to support that in case of issues reported by upstream. Branch alone won't do as we want builds to be reproducible.

According to flathub#307 (review)

Upstream release v1.2.0-rcgit-28

nedrichards · 2018-04-04T06:36:51Z

bot, build org.remmina.Remmina

antenore · 2018-04-04T23:00:49Z

We have found a couple of bugs that impact old distros, like Ubuntu 14.04.
We are working on these bugs ans we will re-tag a new commit or do a new release.

Sorry for the inconvenient.

nedrichards · 2018-04-05T06:42:33Z

No worries, power of upstream!

amtlib-dot-dll · 2018-04-09T02:13:01Z

New tag coming, thanks to @antenore and other upstream Remmina developers!

@nedrichards May you trigger another bot build? Thanks

TingPing · 2018-04-10T09:31:21Z

bot, build org.remmina.Remmina

Per flathub/flathub#307 (review)

According to flathub/flathub#307 (review)

nedrichards · 2018-04-10T10:42:20Z

Repository has been created: https://github.com/flathub/org.remmina.Remmina

nedrichards · 2018-04-10T10:43:49Z

@antenore let us know the github usernames of any other upstream developers who we should add to the new repo.

antenore · 2018-04-10T10:50:59Z

@nedrichards Thanks!

Those in CC to this message

cc @giox069 @larchunix @amtlib-dot-dll

TingPing · 2018-04-10T11:15:54Z

@antenore Added.

antenore · 2022-12-02T14:54:57Z

@nedrichards @TingPing sorry to comment on a closed PR

How to ask for membership changes?

I'd like to remove larchunix and add @myheroyuki

Thanks!

TingPing · 2022-12-02T17:55:41Z

@antenore Done. An invitation was sent.

antenore · 2022-12-02T18:32:13Z

Thank you @TingPing !!!

myheroyuki · 2022-12-03T12:04:20Z

@TingPing Thank you, just accepted

Version update

Copycat

ad9edb1

TingPing reviewed Mar 19, 2018

View reviewed changes

org.remmina.Remmina.json Outdated

"/share/pkgconfig"

],

"finish-args": [

"--own-name=org.remmina.Remmina",

Copy link

Member

TingPing Mar 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed

TingPing reviewed Mar 19, 2018

View reviewed changes

org.remmina.Remmina.json Outdated

},

{

"name": "libssh",

"buildsystem": "cmake",

Copy link

Member

TingPing Mar 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cmake-ninja

TingPing reviewed Mar 19, 2018

View reviewed changes

org.remmina.Remmina.json Outdated

},

{

"name": "remmina",

"buildsystem": "cmake",

Copy link

Member

TingPing Mar 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cmake-ninja

TingPing reviewed Mar 19, 2018

View reviewed changes

org.remmina.Remmina.json Outdated

{

"name": "remmina",

"buildsystem": "cmake",

"config-opts": [

Copy link

Member

TingPing Mar 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-DCMAKE_BUILD_TYPE=Release

larchunix mentioned this pull request Mar 20, 2018

Update flatpak manifest according to feedback from Flathub FreeRDP/Remmina#1526

Merged

Merge from upstream

490caea

Thanks for @larchunix

antenore and others added 2 commits April 4, 2018 00:22

Upstream release v1.2.0-rcgit-28

a1baf9b

Update org.remmina.Remmina.json

860f061

According to flathub#307 (review)

amtlib-dot-dll mentioned this pull request Apr 3, 2018

Upstream release v1.2.0-rcgit-28 amtlib-dot-dll/flathub#2

Merged

Merge pull request #2 from amtlib-dot-dll/v1.2.0-rcgit-28-1

de22302

Upstream release v1.2.0-rcgit-28

Bump to v1.2.0-rcgit.29"

6d596ce

nedrichards pushed a commit to flathub/org.remmina.Remmina that referenced this pull request Apr 10, 2018

Update org.remmina.Remmina.json

196e1ca

Per flathub/flathub#307 (review)

nedrichards pushed a commit to flathub/org.remmina.Remmina that referenced this pull request Apr 10, 2018

Update org.remmina.Remmina.json

0dffb4b

According to flathub/flathub#307 (review)

nedrichards closed this Apr 10, 2018

jbruechert pushed a commit to jbruechert/flathub that referenced this pull request Jul 12, 2024

Merge pull request flathub#307 from tsdgeos/updated_version

38b9ae7

Version update

Create org.remmina.Remmina #307

Create org.remmina.Remmina #307

Conversation

amtlib-dot-dll commented Mar 19, 2018 • edited by nedrichards Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

amtlib-dot-dll Mar 19, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nedrichards commented Mar 19, 2018

nedrichards commented Mar 19, 2018

larchunix commented Mar 20, 2018

nedrichards commented Mar 20, 2018

antenore commented Mar 20, 2018

amtlib-dot-dll commented Mar 21, 2018 • edited Loading

antenore commented Mar 21, 2018

antenore commented Mar 21, 2018

nedrichards commented Mar 21, 2018 via email

antenore commented Mar 21, 2018

amtlib-dot-dll commented Mar 21, 2018

TingPing commented Mar 21, 2018 • edited Loading

TingPing commented Mar 21, 2018 • edited Loading

nedrichards commented Mar 21, 2018

antenore commented Mar 22, 2018

nedrichards commented Mar 22, 2018

antenore commented Mar 22, 2018

amtlib-dot-dll commented Mar 30, 2018

nedrichards commented Apr 1, 2018

antenore commented Apr 1, 2018

nedrichards commented Apr 2, 2018

antenore commented Apr 2, 2018

amtlib-dot-dll commented Apr 3, 2018

antenore commented Apr 3, 2018

barthalion commented Apr 3, 2018

nedrichards commented Apr 4, 2018

antenore commented Apr 4, 2018

nedrichards commented Apr 5, 2018

amtlib-dot-dll commented Apr 9, 2018

TingPing commented Apr 10, 2018

nedrichards commented Apr 10, 2018

nedrichards commented Apr 10, 2018

antenore commented Apr 10, 2018

TingPing commented Apr 10, 2018

antenore commented Dec 2, 2022

TingPing commented Dec 2, 2022

antenore commented Dec 2, 2022

myheroyuki commented Dec 3, 2022

amtlib-dot-dll commented Mar 19, 2018 •

edited by nedrichards

Loading

amtlib-dot-dll Mar 19, 2018 •

edited

Loading

amtlib-dot-dll commented Mar 21, 2018 •

edited

Loading

TingPing commented Mar 21, 2018 •

edited

Loading

TingPing commented Mar 21, 2018 •

edited

Loading