org.virt_manager.virt-viewer #391

AdrianKoshka · 2018-05-13T21:54:23Z

This is a rough-draft PR, I still need to write an appstream file, but mostly everything else seems done.

barthalion · 2018-05-14T07:20:38Z

org.virt-manger.virt-viewer.appdata.xml

@@ -0,0 +1,60 @@
+<!-- https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html -->


Have you submitted this upstream?

Not yet, I'm waiting for upstream to reply to an email I sent to their mailing-list. I'll probably submit this appstream rough-draft to upstream in a following email.

barthalion · 2018-05-14T07:23:29Z

org.virt-manger.virt-viewer.json

+            "sources": [
+                {
+                    "type": "git",
+                    "url": "git://anongit.freedesktop.org/spice/spice-protocol",


Use https here.

nedrichards · 2018-05-14T08:49:33Z

bot, build org.virt_manager.virt-viewer

barthalion · 2018-05-14T18:59:07Z

Filename doesn't match app ID.

AdrianKoshka · 2018-05-14T20:30:55Z

I had been building only remote-viewer before because I didn't know I also needed to build libvirt to build virt-viewer, I'm working on fixing this now. what I intend to happen is when you run flatpak run org.virt_manager.virt-viewer, virt-viewer is ran, but if you run the .desktop of remote-viewer, then remote-viewer is ran.

AdrianKoshka · 2018-05-14T20:43:29Z

I put the wrong https link for that git repo, will push a fix for that too, as soon as I get libvirt to build.

barthalion · 2018-05-14T21:35:39Z

Take my comment literally. id is org.virt_manager.virt-viewer, while the file is named org.virt-manger.virt-viewer.json (note the typo). It's not going to working this way.

AdrianKoshka · 2018-05-14T21:36:17Z

Oh, thanks, I'll fix this.

AdrianKoshka · 2018-05-14T21:55:09Z

This still needs some serious cleanup, but it builds correctly now.

eszlari · 2018-05-14T22:38:49Z

org.virt_manger.virt-viewer.appdata.xml

+  </categories>
+  <url type="homepage">https://virt-manager.org/download/</url>
+  <url type="bugtracker">https://bugzilla.redhat.com/buglist.cgi?bug_status=NEW&bug_status=ASSIGNED&classification=Community&component=virt-viewer&product=Virtualization%20Tools</url>
+  <url type="help">https://support.mozilla.org/questions/thunderbird</url>


Wrong help URL.

Thanks for catching this, I wasn't really able to find a good "help" URL, so I'll just remove that line. Is that okay?

eszlari · 2018-05-14T22:40:29Z

org.virt_manger.virt-viewer.appdata.xml

@@ -0,0 +1,60 @@
+<!-- https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html -->
+<?xml version="1.0" encoding="UTF-8"?>
+<component type="desktop">


No screenshots.

What resolution should screenshots be? As a reference.

eszlari · 2018-05-14T22:49:43Z

org.virt_manger.virt-viewer.json

+            "name": "lz4",
+            "build-options": {
+                "env": {
+                    "PREFIX": "/app"


You use ${FLATPAK_DEST} above.

So are you saying to replace PREFIX with FLATPAK_DEST?

No, see module gcrypt-wrapper. I meant: Use /app or ${FLATPAK_DEST} consistently.

does 72a6936 solve this?

Sure. Not that it does have any effect, it was only a minor style thing.

Thanks, you've been doing a great job of helping me better my manifest.

eszlari · 2018-05-14T22:51:02Z

org.virt_manger.virt-viewer.json

+            },
+            "buildsystem": "simple",
+            "build-commands": [
+                "make",


make -j $FLATPAK_BUILDER_N_JOBS

eszlari · 2018-05-14T22:53:12Z

org.virt_manger.virt-viewer.json

+                "*"
+            ],
+            "build-commands": [
+                "install -Dm755 libgcrypt-config ${FLATPAK_DEST}/bin/libgcrypt-config"


Can be shortened to: install libgcrypt-config ${FLATPAK_DEST}/bin

Sorry, that was wrong. You could only drop the "m755".

eszlari · 2018-05-14T22:56:54Z

org.virt_manger.virt-viewer.appdata.xml

+    <categories>Network</categories>
+  </categories>
+  <url type="homepage">https://virt-manager.org/download/</url>
+  <url type="bugtracker">https://bugzilla.redhat.com/buglist.cgi?bug_status=NEW&bug_status=ASSIGNED&classification=Community&component=virt-viewer&product=Virtualization%20Tools</url>


$ appstream-util validate-relax org.virt_manger.virt-viewer.appdata.xml org.virt_manger.virt-viewer.appdata.xml: failed to parse org.virt_manger.virt-viewer.appdata.xml: Error on line 16: Entity did not end with a semicolon; most likely you used an ampersand character without intending to start an entity - escape ampersand as &

nedrichards · 2018-05-16T14:44:10Z

bot, build bot, build org.virt_manager.virt-viewer

AdrianKoshka · 2018-05-16T23:53:47Z

So now I've gotten virt-viewer in a working state, the next problem I need to tackle is getting virt-viewer to connect to qemu:///system. qemu:///system is the URI for qemu/libvirt running on that local machine.

I think this would need to be done by passing a file through to the sandbox via --filesystem= (because virt-viewer looks for a file which is a socket). I'll also start working on bettering the appstream file.

nedrichards · 2018-05-17T18:13:54Z

bot, build org.virt_manager.virt-viewer

AdrianKoshka · 2018-05-22T01:13:37Z

Sorry for the radio silence, I was on vacation and went to an event over the past weekend.

nedrichards · 2018-05-22T14:11:34Z

No worries at all! "Having A Life" is not a problem, when you're donating your time for free you don't owe anybody anything (unless you want to).

AdrianKoshka · 2018-05-23T19:14:46Z

I don't think I'll be able to make USB redirection work, mostly because almost all of /dev is read-only.

All mounts are read-only, except:

root tmpfs (e.g. for tmp subdir and transient home)

/var

/proc (except /proc/sys, proc/sysrq-trigger, /proc/irq and /proc/bus which are
read-only)

/dev/pts

/dev/shm

Another thing I haven't worked out is how to connect to qemu:///system, which is qemu(kvm)/libvirtd running on the host. virt-viewer seemingly needs /var/run/libvirt/libvirt-sock-ro.

Also a way to pass the SSH-agent of the host through to the flatpak.

nedrichards · 2018-05-25T10:48:00Z

bot, build org.virt_manager.virt-viewer

AdrianKoshka · 2018-05-29T19:16:25Z

As long as the appstream data is fine, I think I'm fine with merging this in it's current state. I think more people will use remote-viewer anyway (which mostly works, sans usb-redirection, but boxes also has this problem).

barthalion · 2018-07-04T13:29:27Z

org.virt_manger.virt-viewer.json

+            "sources": [
+                {
+                    "type": "archive",
+                    "url": "https://github.com/gentoo/eudev/archive/v3.2.5.tar.gz",


We have it in shared-modules: https://github.com/flathub/shared-modules/tree/master/udev

I think the version in shared modules was out of date for my needs.

barthalion · 2018-07-04T13:30:23Z

org.virt_manger.virt-viewer.json

+            "sources": [
+                {
+                    "type": "archive",
+                    "url": "https://libvirt.org/sources/libvirt-4.3.0.tar.xz",


Not sure if it matters for app functionality, but 4.4.0 is o ut.

Updated it (and a few other things) anyway.

barthalion · 2018-07-04T13:33:17Z

org.virt_manger.virt-viewer.json

+        "--talk-name=org.a11y.*",
+        "--device=all",
+        "--filesystem=xdg-pictures",
+        "--filesystem=~/.ssh",


There is also --socket=ssh-auth now, but I'm not sure if it's enough for ssh to work.

I plan on testing this tonight.

I'm also thinking of adding dri, becasue spice can leverage openGL for rendering.

So, while the ssh-auth socket is enough for ssh to work on a basic level, if ~/.ssh isn't passed through, it seemingly doesn't create a known_hosts file, and will always prompt the user whether they trust the fingerprint or not.

nedrichards · 2018-07-05T08:29:05Z

bot, build org.virt_manager.virt-viewer

barthalion · 2018-07-06T07:13:07Z

JSON manifest has typo in the filename, it h=should be org.virt_manager.virt-viewer, not manger.

AdrianKoshka · 2018-07-06T17:11:44Z

Thanks.

barthalion · 2018-07-09T07:44:23Z

bot, build org.virt_manager.virt-viewer

barthalion · 2018-07-09T14:20:09Z

Makefile

@@ -0,0 +1,18 @@
+TARGET_REPO = repo
+FLATPAK_BUILDER = $(shell which flatpak-builder)
+MANIFEST = org.virt_manger.virt-viewer.json


Here is also a typo. I'd rather remove Makefile completely.

barthalion · 2018-07-09T14:21:14Z

org.virt_manager.virt-viewer.appdata.xml

@@ -0,0 +1,74 @@
+<!-- https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html -->


You are not installing this file anywhere. Have you submitted it upstream too?

Haven't yet, the last time I tried to contact upstream I got absolutely nothing back.

nedrichards · 2018-07-13T11:14:30Z

bot, build org.virt_manager.virt-viewer

nedrichards · 2018-08-31T14:00:44Z

bot, build org.virt_manager.virt-viewer

AdrianKoshka · 2018-09-13T03:00:25Z

Not happy with how this flatpak operates. Mostly do USB redirection not working. I don't think I'll be submitting it after-all. I guess if anyone wants to pick it up in future, I could help them though. Thanks for all the help, apologies for the wasted effort.

AdrianKoshka added 2 commits May 13, 2018 17:44

[init]

4f1add3

[AppStream] add a roughdraft

5a8439a

barthalion reviewed May 14, 2018

View reviewed changes

[flatpak] change to https

f317d45

[fixes] pull in libvirt + libvirt-glib, fix repo url and file name(s)

509f6af

eszlari reviewed May 14, 2018

View reviewed changes

AdrianKoshka added 6 commits May 14, 2018 19:01

[appstream] remove incorrect help entry

468b280

[flatpak] cleanup some dirs, and compile w/o tests or completions

ca52e49

[flatpak] shuffle around build order, have most libraries build first

5691227

[flatpak] open up ~/.ssh and add more depends

4becb28

[flatpak] nc isn't needed

05ca41e

[flatpak] remove uneeded config-opts for libvirt

6caeaba

[flatpak] build libvirt properly, virt-viewer now works

5a5c562

AdrianKoshka added 3 commits May 16, 2018 19:56

[AppStream] replace & with escaped ampersands

c489e9c

[flatpak] tell lz4 to use as many cores are avialable

ac42994

[flatpak] drop install perms

8e034a3

AdrianKoshka added 3 commits May 16, 2018 21:35

[flatpak] libssh2 isn't needed

ad17dc2

[flatpak] don't build libnl cli tools

713d54c

org.virt_manger.virt-viewer.json

72a6936

barthalion added the work-in-progress Draft PRs label May 19, 2018

AdrianKoshka added 2 commits May 25, 2018 01:49

[AppData] add some screenshots

6df271b

[AppData] add some spacing

71c6d06

barthalion reviewed Jul 4, 2018

View reviewed changes

[flatpak] update certain depends, and add ssh socket

875ae7d

[flatpak] rename manifest and appdata files to fix a typo

3497990

barthalion requested changes Jul 9, 2018

View reviewed changes

[rm] not needed

dfd5bde

AdrianKoshka added 2 commits August 30, 2018 20:12

[flatpak] bump virt-viewer to 7.0

92d4489

[AppData] bump to 7.0

98335a5

AdrianKoshka closed this Sep 13, 2018

kowalski7cc mentioned this pull request Jan 13, 2023

Publish org.virt_manager.virt-viewer #3807

Closed

7 tasks

		@@ -0,0 +1,60 @@
		<!-- https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html -->

		@@ -0,0 +1,74 @@
		<!-- https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html -->

org.virt_manager.virt-viewer #391

org.virt_manager.virt-viewer #391

Conversation

AdrianKoshka commented May 13, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nedrichards commented May 14, 2018

barthalion commented May 14, 2018

AdrianKoshka commented May 14, 2018

AdrianKoshka commented May 14, 2018

barthalion commented May 14, 2018

AdrianKoshka commented May 14, 2018

AdrianKoshka commented May 14, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nedrichards commented May 16, 2018

AdrianKoshka commented May 16, 2018

nedrichards commented May 17, 2018

AdrianKoshka commented May 22, 2018

nedrichards commented May 22, 2018

AdrianKoshka commented May 23, 2018 • edited Loading

nedrichards commented May 25, 2018

AdrianKoshka commented May 29, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nedrichards commented Jul 5, 2018

barthalion commented Jul 6, 2018

AdrianKoshka commented Jul 6, 2018

barthalion commented Jul 9, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nedrichards commented Jul 13, 2018

nedrichards commented Aug 31, 2018

AdrianKoshka commented Sep 13, 2018

AdrianKoshka commented May 14, 2018 •

edited

Loading

AdrianKoshka commented May 23, 2018 •

edited

Loading