Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add org.gnome.Loupe #4048

Closed
wants to merge 3 commits into from
Closed

Conversation

sophie-h
Copy link

@sophie-h sophie-h commented Apr 4, 2023

Please confirm your submission meets all the criteria

  • I have read the App Requirements and App Maintenance pages.
  • My pull request follows the instructions at App Submission.
  • I am using only the minimal set of permissions. (If not, please explain each non-standard permission.)
  • All assets referenced in the manifest are redistributable by any party. If not, the unredistributable parts are using an extra-data source type.
  • I am an upstream contributor to the project. If not, I contacted upstream developers about submitting their software to Flathub. Link:
  • I own the domain used in the application ID or the domain has a policy for delegating subdomains (e.g. GitHub, SourceForge).
  • Any additional patches or files have been submitted to the upstream projects concerned. (If not, explain why.)

@sophie-h
Copy link
Author

sophie-h commented Apr 4, 2023

bot, build org.gnome.Loupe

@flathubbot
Copy link

Queued test build for org.gnome.Loupe.

@flathubbot
Copy link

Started test build 32847

@flathubbot
Copy link

Build 32847 failed

@sophie-h sophie-h changed the title Add org.gnome.Loupe.yml Add org.gnome.Loupe Apr 4, 2023
@sophie-h
Copy link
Author

sophie-h commented Apr 4, 2023

bot, build org.gnome.Loupe

@flathubbot
Copy link

Queued test build for org.gnome.Loupe.

@flathubbot
Copy link

Started test build 32849

@flathubbot
Copy link

Build 32849 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/15484/org.gnome.Loupe.flatpakref

@sophie-h
Copy link
Author

sophie-h commented Apr 4, 2023

bot, build org.gnome.Loupe

@flathubbot
Copy link

Queued test build for org.gnome.Loupe.

@flathubbot
Copy link

Started test build 32857

@sophie-h
Copy link
Author

sophie-h commented Apr 4, 2023

Please add @BrainBlasted as admin for the Loupe Flathub repo as well after acceptance

@flathubbot
Copy link

Build 32857 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/15492/org.gnome.Loupe.flatpakref

org.gnome.Loupe.yml Outdated Show resolved Hide resolved
@sophie-h sophie-h marked this pull request as ready for review April 4, 2023 23:28
- --socket=wayland
- --device=dri
# Browse through photos
- --filesystem=host
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is very broad as a permission.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There hasn't been any progress on the relevant portal for years flatpak/xdg-desktop-portal#463

People don't have images only in their Pictures folder. They also have graphics they are working on etc and want to flip through. Also, they want to open them from the file browser or terminal.

org.gnome.Loupe.yml Outdated Show resolved Hide resolved
org.gnome.Loupe.yml Outdated Show resolved Hide resolved
sophie-h and others added 2 commits April 5, 2023 01:35
Co-authored-by: Hubert Figuière <hub@figuiere.net>
Co-authored-by: Hubert Figuière <hub@figuiere.net>
@barthalion
Copy link
Member

bot, build org.gnome.Loupe

@flathubbot
Copy link

Queued test build for org.gnome.Loupe.

@flathubbot
Copy link

Started test build 32982

@flathubbot
Copy link

Build 32982 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/15618/org.gnome.Loupe.flatpakref

@barthalion
Copy link
Member

For some reason, nothing happens when I set Loupe as the default image viewer and try to open a png file in Nautilus. I don't see anything in journalctl, though. Do you have any suggestions on how to make this more useful to you?

@sophie-h
Copy link
Author

sophie-h commented Apr 5, 2023

Works for me with the build from here. I suggest tracking bug reports in Loupe's issue tracker.

Screencast.from.2023-04-05.15-26-22.webm

@barthalion
Copy link
Member

Weird, but if it works for you, so be it.

/merge @BrainBlasted

@flathubbot
Copy link

A repository for this submission has been created: https://github.com/flathub/org.gnome.Loupe

You will receive an invitation to be a collaborator which will grant you write access to the repository above. The invite can be also viewed here.

If you have never maintained an application before, common questions are answered in the app maintenance guide.

Thanks!

@flathubbot flathubbot closed this Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants