Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rocks.poopjournal.librelinkupdesktop #5086

Conversation

CrazyMarvin
Copy link

@CrazyMarvin CrazyMarvin commented Mar 25, 2024

Please confirm your submission meets all the criteria

  • Please describe your application briefly.

This is a desktop application that fetches your blood sugar from LibreLinkUp.

Features of LibreLinkUpDesktop:

  • Show blood glucose level on your desktop in a little window

  • No tracking

  • Dark Mode

  • Libre software

  • That's it. 🩸

  • I have read the App Requirements and App Maintenance pages.

  • My pull request follows the instructions at App Submission.

  • I have built and tested the submission locally.

  • I am using only the minimal set of permissions. (If not, please explain each non-standard permission.)

  • All assets referenced in the manifest are redistributable by any party. If not, the unredistributable parts are using an extra-data source type.

  • I am an author/developer/upstream contributor of the project. If not, I contacted upstream developers about submitting their software to Flathub. Link:

  • The domain used for the application ID is controlled by the application developers either directly or through the code hosting (e.g. GitHub, GitLab, SourceForge, etc.). The application id guidelines are followed.

  • Any additional patches or files have been submitted to the upstream projects concerned. (If not, explain why.)

@CrazyMarvin
Copy link
Author

bot, build rocks.poopjournal.librelinkupdesktop

@flathubbot
Copy link

Queued test build for rocks.poopjournal.librelinkupdesktop.

Copy link
Contributor

@hfiguiere hfiguiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also I don't see any icons, .desktop or appstream file installed.

@flathubbot
Copy link

Started test build 109878

@CrazyMarvin
Copy link
Author

also I don't see any icons, .desktop or appstream file installed.

I just copied it from the sample and hoped it would build. 😅
I will have a closer look later.

@hfiguiere
Copy link
Contributor

Also you failed to:

Please describe your application briefly.

(the checkboxes are not a CAPTCHA)

@flathubbot
Copy link

Build 109878 failed

@bbhtt bbhtt added awaiting-changes Pull request waiting for inputs or changes from author blocked Pull requests that are blocked on something or won't be accepted in the currrent state labels Mar 26, 2024
@CrazyMarvin
Copy link
Author

Do you recommend to put some files like the Flathub Manifest or MetaInfo File into the upstream repo or is it fine to have everything just here?

@hfiguiere
Copy link
Contributor

Do you recommend to put some files like the Flathub Manifest or MetaInfo File into the upstream repo or is it fine to have everything just here?

Upstream is always best. The ideal flathub repo contain only the manifest file.

@hfiguiere
Copy link
Contributor

Definitely NEVER the upstream source or distribution

In that case the generated-sources.json is missing should be in the repo.

@bbhtt
Copy link
Contributor

bbhtt commented Apr 2, 2024

also I don't see any icons, .desktop or appstream file installed.

This is still missing I think

@fperera123
Copy link

bot, build rocks.poopjournal.librelinkupdesktop

@flathubbot
Copy link

Queued test build for rocks.poopjournal.librelinkupdesktop.

@flathubbot
Copy link

Started test build 111953

@fperera123
Copy link

also I don't see any icons, .desktop or appstream file installed.

These are now added

@flathubbot
Copy link

Build 111953 failed

@flathubbot
Copy link

Queued test build for rocks.poopjournal.librelinkupdesktop.

@flathubbot
Copy link

Started test build 112587

@flathubbot
Copy link

Build 112587 failed

@fperera123
Copy link

bot, build rocks.poopjournal.librelinkupdesktop

@flathubbot
Copy link

Queued test build for rocks.poopjournal.librelinkupdesktop.

@flathubbot
Copy link

Started test build 112598

@flathubbot
Copy link

Build 112598 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/95408/rocks.poopjournal.librelinkupdesktop.flatpakref

@CrazyMarvin
Copy link
Author

Build 112598 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/95408/rocks.poopjournal.librelinkupdesktop.flatpakref

This looks fine. 🥳

@fperera123
Copy link

bot, build rocks.poopjournal.librelinkupdesktop

@flathubbot
Copy link

Queued test build for rocks.poopjournal.librelinkupdesktop.

@fperera123
Copy link

bot, build rocks.poopjournal.librelinkupdesktop

@flathubbot
Copy link

Queued test build for rocks.poopjournal.librelinkupdesktop.

@flathubbot
Copy link

Started test build 112651

@flathubbot
Copy link

Build 112651 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/95464/rocks.poopjournal.librelinkupdesktop.flatpakref

Co-authored-by: bbhtt <bbhtt.zn0i8@slmail.me>
@fperera123
Copy link

bot, build rocks.poopjournal.librelinkupdesktop

@flathubbot
Copy link

Queued test build for rocks.poopjournal.librelinkupdesktop.

@flathubbot
Copy link

Started test build 112732

@flathubbot
Copy link

Build 112732 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/95543/rocks.poopjournal.librelinkupdesktop.flatpakref

@bbhtt bbhtt added ready Pull request ready for final review and merge and removed awaiting-changes Pull request waiting for inputs or changes from author blocked Pull requests that are blocked on something or won't be accepted in the currrent state labels Apr 7, 2024
@barthalion
Copy link
Member

/merge

@flathubbot
Copy link

A repository for this submission has been created: https://github.com/flathub/rocks.poopjournal.librelinkupdesktop

You will receive an invitation to be a collaborator which will grant you write access to the repository above. The invite can be also viewed here.

If you have never maintained an application before, common questions are answered in the app maintenance guide.

Thanks!

@flathubbot flathubbot closed this Apr 7, 2024
@CrazyMarvin
Copy link
Author

Thanks to everyone! 😍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Pull request ready for final review and merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants