Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify GLib minimum version #16

Closed
tintou opened this issue Jan 7, 2020 · 4 comments · Fixed by #27
Closed

Specify GLib minimum version #16

tintou opened this issue Jan 7, 2020 · 4 comments · Fixed by #27

Comments

@tintou
Copy link

tintou commented Jan 7, 2020

I couldn't build it on elementary 5.1 because g_hash_table_steal_extended is missing, it has been added in GLib 2.58 so it might be reasonable to specify 2.58 as the minimal supported version
@trappedinspacetime
Copy link

trappedinspacetime commented Mar 14, 2020 •
edited
Loading

Yes, it breaks the compatibility on Ubuntu 16.04. Do we have any chance to port that function to glib 2.48.2 ?

@tintou
Copy link
Author

tintou commented Mar 14, 2020

@trappedinspacetime We are patching it in elementary OS (Ubuntu 18.04) to substitute this function and lower our GLib requirements elementary/os-patches@b83fe31

@trappedinspacetime
Copy link

@tintou Thank you very much. I was thinking of building GLIB-2.64.
and adding its library.
But we have other dependency issues with xdg-desktop-portal and xdg-desktop-portal

hadess added a commit that referenced this issue Mar 26, 2020
@hadess
build: Bump required glib version
93dd961 
g_hash_table_steal_extended() is new in glib 2.58.

Closes: #16
@hadess
Copy link
Contributor

hadess commented Mar 26, 2020

Yes, it breaks the compatibility on Ubuntu 16.04. Do we have any chance to port that function to glib 2.48.2 ?

There's really no reason to support this old version of Ubuntu, libportal is supposed to be used inside the sandbox, not outside it.

@hadess hadess mentioned this issue Mar 26, 2020
Merged
grulja pushed a commit to grulja/libportal that referenced this issue Jun 28, 2021
@hadess @grulja
build: Bump required glib version
b6f2911 
g_hash_table_steal_extended() is new in glib 2.58.

Closes: flatpak#16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: Bump required glib version flatpak/libportal
3 participants
@tintou @hadess @trappedinspacetime