-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace the SimilaritySurface hierarchy with categories #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
we stick to Euclidean polygons in the (finite) real plane for the time being. Many of the statements/comments/methods were a bit nonsensical actually in the setup that used "real projective plane".
mamba segfaults in some situations in CI
so we do not work around the missing is_diagonal() of matrices.
Documentation preview for this PR is ready! 🎉 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #132 and hopefully gets rid of all of the boilerplate that is currently necessary to expose functionality in both surface hierarchies.
Checklist
doc/news/
.doc/geometry
ordoc/graphical
.Dependencies
TODO
__eq__
should be a very strict notion of equality always (same type & indistinguishable); make sure this is always the case and documentedlabels()
does not work for non-connected surfaces; this is not a new problem. There is only a single base label so how should we iterate non-connected surfaces?#TODO
markers in the code anymore.Fix Speed Regressions
Generically, some tests deteriorated:
similarity_surface.py
+rational_similarity_surface.py
3s → 11.2s → 5.6s → 3sdelaunay.py
2.16s → 15.03s → 4sfundamental_group.py
0.29s → 0.97s → 0.19smappings.py
0.37s → 0.82s → 0.4sThere are specific problems with performance:
is_rational_surface()
(which is new) is very slow. (but it's not called automatically anymore.)