-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Branch for 2.4 release #1006
Merged
Merged
Branch for 2.4 release #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on surfaces are outside of the domain
fix: plot 3d format
…e source or monitors
…em variable is not empty
updated changelog
Added reference for Germanium material model from Burnett et al.
- updated based on PR comments
* Use pytest's tmp path instead of hard-codded ones Hard-codded paths can be an issue when tests are run in parallel or unordered, particularly in Windows. This commit removes all hard-codded paths from the test suite, replacing them with pytest's tmp_path fixture, which is also automatically cleaned after run. A few ruff warnings were also cleaned up in the process: mostly unused imports and variables, and warnings caused by a large number of matplotlib figures being created. --------- Signed-off-by: Lucas Heitzmann Gabrielli <lucas@flexcompute.com>
Offset target_neff slightly in mode solver to avoid singular matrix
Signed-off-by: Lucas Heitzmann Gabrielli <lucas@flexcompute.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.