Skip to content

Escaping web dependence in invdes plugin until needed #2006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2024
Merged

Escaping web dependence in invdes plugin until needed #2006

merged 1 commit into from
Oct 9, 2024

Conversation

momchil-flex
Copy link
Collaborator

No description provided.

@momchil-flex
Copy link
Collaborator Author

In the end, I didn't really end up needing the explicit AbstractInverseDesign.run functions on the backend, so I could just do the lazy import in the old code. But the lazy import did fix my test that the optimization can be loaded, and metadata processed, without needing web dependencies.

momchil-flex
momchil-flex commented Oct 7, 2024
View reviewed changes
tylerflex
tylerflex approved these changes Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@tylerflex tylerflex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

yaugenst-flex
yaugenst-flex approved these changes Oct 8, 2024
View reviewed changes
@momchil-flex momchil-flex merged commit cc857f9 into develop Oct 9, 2024
15 checks passed
@momchil-flex momchil-flex deleted the momchil/invdes_web branch October 9, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaugenst-flex yaugenst-flex yaugenst-flex approved these changes

@tylerflex tylerflex tylerflex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@momchil-flex @tylerflex @yaugenst-flex