Skip to content

Fix metric validator for float case #2013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Fix metric validator for float case #2013

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions tidy3d/plugins/invdes/design.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,9 +179,10 @@ def _validate_metric_f(metric: Metric, simulation: td.Simulation) -> None:
"""Validate that the frequencies of the metric are present in the monitor."""
monitor = next((m for m in simulation.monitors if m.name == metric.monitor_name), None)
if metric.f is not None:
if len(metric.f) != 1:
metric_f_list = [metric.f] if isinstance(metric.f, float) else metric.f
if len(metric_f_list) != 1:
raise ValidationError("Only a single frequency is supported for the metric.")
for freq in metric.f:
for freq in metric_f_list:
if not any(np.isclose(freq, monitor.freqs, atol=1.0)):
raise ValidationError(
f"Frequency '{freq}' for metric associated with monitor "
Expand Down
Loading