Polygon triangulation supports collinear vertices #2034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
momchil-flex
approved these changes
Oct 24, 2024
Signed-off-by: Lucas Heitzmann Gabrielli <lucas@flexcompute.com>
lucas-flexcompute
force-pushed
the
lucas/fix/triangulation
branch
from
ff9ce2c to
7431da0
Compare
|
Awesome btw tested that this un-stucks the problematic sim! You probably did as well but I verified. |
weiliangjin2021
approved these changes
Oct 24, 2024
Signed-off-by: Lucas Heitzmann Gabrielli <lucas@flexcompute.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for our ear clipping triangulation algorithm to work with polygons with collinear vertices.
It also adds a safeguard in the main loop to error if no progress is made, so that we don't get stuck jobs due to numerical issues.