Skip to content

Ops 3543 handle empty string #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Ops 3543 handle empty string #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
37bf4bf
OPS-3543 handling the case where the api hits a 500 and returns an em…
netguino Oct 31, 2016
6d6e9c4
OPS-3543 handling the case where the api hits a 500 and returns an em…
netguino Oct 31, 2016
279cea7
OPS-3543 handling the case where the api hits a 500 and returns an em…
netguino Oct 31, 2016
1e43fc3
OPS-3543 fixed minor styling
netguino Oct 31, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1.6.1
1.6.2
11 changes: 5 additions & 6 deletions lib/right_api_client/client.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,11 +397,11 @@ def do_get(path, params={})
raise wrap(e, :get, path, params, req, res)
end

data = if resource_type == 'text'
{ 'text' => body }
else
JSON.parse(body, :allow_nan => true)
end
data = if resource_type == 'text' || resource_type == ''
{ 'text' => body }
else
JSON.parse(body, :allow_nan => true)
end

[resource_type, path, data]
end
Expand Down Expand Up @@ -664,4 +664,3 @@ def update_api_url(response)
end
end
end