-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLI-1123] Support bulk flag evaluation in OFREP #3332
Comments
One thing to think about re implementing this: Flipt requires flagKey for each bulk evaluation request, whereas OFREP spec does not specify it. However, they do state that we can 'filter' which flags to evaluate in the request context: https://github.com/open-feature/protocol/blob/218fd82f1d37844f26ec22418655a44395fbd3f4/service/adrs/0004-no-flag-filter-in-bulk-evaluation-request.md So it would be a 1 to N mapping, one batch eval request on the OFREP side would map to N requests in the bridge, where N is the length of We could return an error Similarly for the namespaceKey (provided in |
* feat(ofrep): implement bulk evaluation for OFREP resolves #3332 --------- Signed-off-by: Roman Dmytrenko <rdmytrenko@gmail.com> Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com> Co-authored-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
Problem
Re: #2980
We have single flag evaluation in #3267 (thanks @thepabloaguilar !)
We should support bulk flag evaluation https://github.com/open-feature/protocol/blob/218fd82f1d37844f26ec22418655a44395fbd3f4/service/openapi.yaml#L84
Then we will be compatible with the current ofrep specification
Ideal Solution
support bulk flag evaluation https://github.com/open-feature/protocol/blob/218fd82f1d37844f26ec22418655a44395fbd3f4/service/openapi.yaml#L84 in Flipt OFREP server
Search
Additional Context
No response
FLI-1123
The text was updated successfully, but these errors were encountered: