-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ofrep): implement bulk evaluation for OFREP #3364
Conversation
Signed-off-by: Roman Dmytrenko <rdmytrenko@gmail.com>
aed95fa
to
7c8f50b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3364 +/- ##
==========================================
+ Coverage 64.42% 64.55% +0.13%
==========================================
Files 172 172
Lines 13824 13871 +47
==========================================
+ Hits 8906 8955 +49
+ Misses 4234 4230 -4
- Partials 684 686 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Roman Dmytrenko <rdmytrenko@gmail.com>
d6c5a95
to
f887edb
Compare
I don't have an idea how it is possible to add integration test for this. Go ofrep provider doesn't support This is a minimal setup for import { OFREPWebProvider } from "@openfeature/ofrep-web-provider";
import { OpenFeature } from "@openfeature/web-sdk";
const ctx = { targetingKey: "fruit", flags: "variant-flag,boolean-flag" };
const o = new OFREPWebProvider(
{ baseUrl: "http://host.docker.internal:8080" },
console
);
OpenFeature.setContext(ctx);
await OpenFeature.setProviderAndWait(o);
const result = OpenFeature.getClient().getStringValue("variant-flag", "default");
console.log("result", result);
OpenFeature.close(); |
Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! We could add ITs for the bulk eval endpoints using plain HTTP/REST in a future PR
resolves #3332