Update tutorial 11 #751
Merged
Update tutorial 11 #751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…torial-page-links
kevin-thankyou-lin
requested review from
AboudyKreidieh,
cathywu,
eugenevinitsky and
kanaadp
as code owners
|
Question, is it not possible to set a fixed departure speed? |
Pull Request Test Coverage Report for Build 4596
💛 - Coveralls |
|
Oh yes, I can set a fixed departure speed and submit another PR.
…On Mon, 7 Oct 2019 at 4:36 PM, Coveralls ***@***.***> wrote:
Pull Request Test Coverage Report for Build 4577
<https://coveralls.io/builds/26168354>
- *0* of *0* changed or added relevant lines in *0* files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage remained the same at *90.914%*
------------------------------
Totals [image: Coverage Status] <https://coveralls.io/builds/26168354>
Change from base Build 4566 <https://coveralls.io/builds/26126594>: 0.0%
Covered Lines: 9205
Relevant Lines: 10125
------------------------------
💛 - Coveralls <https://coveralls.io>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#751?email_source=notifications&email_token=AH6MY6ISJPR55UD6MEDUHYLQNPBYNA5CNFSM4I6K4ZG2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEASEWPA#issuecomment-539249468>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AH6MY6LFZMV5RUEULRNT7NTQNPBYNANCNFSM4I6K4ZGQ>
.
|
|
You can also just push another commit to this PR! |
| "- `depart_speed`: this parameter lets you specify the speed at which the vehicles will enter the network. It should be a positive `float`, in meters per second. If this speed is unsafe, the departure of the vehicles is delayed. Just like for `depart_lane`, there are other options for this parameter, which are the following strings:\n", | ||
| "\n", | ||
| " - `\"random\"`: vehicles enter the edge with a random speed between 0 and the speed limit on the edge. The entering speed may be adapted to ensure that a safe distance to the leading vehicle is kept\n", | ||
| " - `\"speedLimit\"`: vehicles enter the edge with the maximum speed that is allowed on this edge. If that speed is unsafe, the departure is delayed.\n", |
There was a problem hiding this comment.
don't delete this. replace "speedLimit" with "max", see: https://sumo.dlr.de/docs/Simulation/VehicleInsertion.html
|
Got it!
…On Tue, 8 Oct 2019 at 12:43 PM, Aboudy Kreidieh ***@***.***> wrote:
***@***.**** commented on this pull request.
Other than comment this LGTM
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#751?email_source=notifications&email_token=AH6MY6OA2SJAR4WIGFXS6ITQNTPH3A5CNFSM4I6K4ZG2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCHJHFKA#pullrequestreview-299004584>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AH6MY6JQF5DDA6G43XHXWA3QNTPH3ANCNFSM4I6K4ZGQ>
.
|
… speed as a constant
…eparture speed as a constant" This reverts commit 77ebb92.
|
Made the changes! |
|
Thanks Kevin! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request information
Description
Updated import modules, fixed typos and removed a version dependent inflow parameter for departure_speed (speedLimit).