Update tutorials to match with the new way of running experiments #802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashkan-software
requested review from
AboudyKreidieh,
cathywu,
eugenevinitsky and
kanaadp
as code owners
Pull Request Test Coverage Report for Build 4922
💛 - Coveralls |
| "\n", | ||
| "# create the experiment object\n", | ||
| "exp = Experiment(env)\n", | ||
| "flow_params = dict(\n", |
There was a problem hiding this comment.
can you add the descriptions to each parameter the way we do in the examples?
There was a problem hiding this comment.
Actually I removed the descriptions for 2 reasons: 1- It would make the tutorial kind of long. I realized most of code snippets in the tutorials are short, not to distract the reader. 2- Those parameters are all explained before in the tutorial.
@AboudyKreidieh I am open to discussing. What do you think?
There was a problem hiding this comment.
sounds good to me. So long as we agree it makes the tutorials clearer
AboudyKreidieh
approved these changes
Dec 25, 2019
|
@AboudyKreidieh can you please check my last commit and confirm it is correct? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request information
Description
Update tutorials to match with the new way of running experiments. This is one of the tasks of #720 that was excluded from the PR as that PR was getting huge.