Local collection updated but never queried

[dbmalkovsky]

In org.flowable.editor.dmn.converter.DmnJsonConverter.java there appears that in two occasions where there is a mismatch between the updating and querying of a collection.

In the first case inputClauseMap is added to but never queried; starting around line 100:

        Map<String, InputClause> inputClauseMap = new HashMap<>();
        ArrayNode inputExpressionsNode = objectMapper.createArrayNode();

        for (InputClause clause : definition.getCurrentDecisionTable().getInputs()) {

            LiteralExpression inputExpression = clause.getInputExpression();
            inputClauseMap.put(inputExpression.getId(), clause);

            ObjectNode inputExpressionNode = objectMapper.createObjectNode();
            inputExpressionNode.put("id", inputExpression.getId());
            inputExpressionNode.put("type", inputExpression.getTypeRef());
            inputExpressionNode.put("label", inputExpression.getLabel());
            inputExpressionNode.put("variableId", inputExpression.getText());

            inputExpressionsNode.add(inputExpressionNode);
        }

The second case is for the variable outputClauseMap starting around line 120:

        Map<String, OutputClause> outputClauseMap = new HashMap<>();
        ArrayNode outputExpressionsNode = objectMapper.createArrayNode();

        for (OutputClause clause : definition.getCurrentDecisionTable().getOutputs()) {

            outputClauseMap.put(clause.getId(), clause);

            ObjectNode outputExpressionNode = objectMapper.createObjectNode();
            outputExpressionNode.put("id", clause.getId());
            outputExpressionNode.put("type", clause.getTypeRef());
            outputExpressionNode.put("label", clause.getLabel());
            outputExpressionNode.put("variableId", clause.getName());

            outputExpressionsNode.add(outputExpressionNode);
        }

This should be reviewed to see if the code is unneeded or there is some other error.

[tijsrademakers]

The maps didn't have a purpose, so removed them.