Windows support #42
Comments
|
What does a few issues mean? I'm currently seeing the outline view and nothing else. Is that what I should be seeing on Windows or are some of you in a more functional state than me? |
|
I'm not sure what "a few issues" means, personally it's completely broken as the LSP only responds to the outline view requests, every other part of it returns |
|
For me it means that it is not usable at all in the current state 😞 - I only have the outline, but no errors show up. |
|
This makes it unusable for my team as well. Is there something we can do to help? I have not done any Atom development in the past, but would really like to give this a go, but we use Flow, and I'm on Windows. |
|
There's a pull request here that apparently adds Windows support to the flow-language-server but hasn't been merged for over a month... |
|
Just published flow-language-server@0.2.4 with @janicduplessis's fixes. 1e93e38 has the version bump so I'd appreciate it if any Windows users here were able to test it out, as I haven't had a chance to do that yet! |
|
I'll give it a try 😉. |
|
Looks like it's finally working for me! 🎉
|
|
I'm a bit lost. On my system, I simply install flow-bin from npm. What do I have to do to make use of this new commit? |
|
@jcowgar The simplest way would be to close all instances of Atom, and then run the following: apm uninstall ide-flowtype
apm install ide-flowtypeThis should make it re-download the dependencies, and since |
|
Awesome! I'll go ahead and publish a new release to bump everyone's versions. |
|
@Arcanemagus Thanks, I didn't realize it was so simple. I followed your instructions and I have flow errors! Didn't think I'd be happy to see them! So, it's working here! Thanks @hansonw! |
|
Glad to hear, happy holidays! :) Closing this out for now, please let us know if you find any other specific problems on Windows. |
|
@hansonw I've been using this for a while now, it's not perfect but usable. The main issue left is caused by vscode-uri because it lowercases drive letters and path comparaisons in atom are case sensitive. I opened an issue on vscode but I'm not sure how likely it is to get fixed upstream. It's not an issue for vs-code because they do other kind of path normalization that lowercases paths on Windows. |
|
@janicduplessis There were several changes made to your facebookarchive/flow-language-server#58 PR, maybe those remaining issues you had are fixed there? |
|
Current File Only switch does not work. It does not show any results regardless of the current file you are editing. I notice what @janicduplessis mentioned. In the "Path" column of the "Diagnostics" pane, it shows a lowercase drive letter, while hovering over the file tab shows an uppercase drive letter. I am not sure if that is the problem, but seems likely w/the error reported above. I did upgrade to the version you pushed out in Atom. |
|
Ah... it must be that vscode-uri does the same lowercase normalization
while creating file URIs, not just when parsing it. I'll have to verify
this but it'll be a simple fix if that's the case.
…On Thu, Dec 28, 2017 at 8:34 PM Jeremy Cowgar ***@***.***> wrote:
Current File Only switch does not work. It does not show any results
regardless of the current file you are editing. I notice what
@janicduplessis <https://github.com/janicduplessis> mentioned. In the
"Path" column of the "Diagnostics" pane, it shows a lowercase drive letter,
while hovering over the file tab shows an uppercase drive letter. I am not
sure if that is the problem, but seems likely w/the error reported above.
I did upgrade to the version you pushed out in Atom.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#42 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAjPYtP4bagXdCpM_PxkGc7ksBIvhQc1ks5tFGvJgaJpZM4QflB8>
.
|
|
@hansonw Yes it's possible, if I remember correctly the issue was that errors did show up in the diagnostics panel, but not underlined in the code because atom would not recognize that it's in the opened file because of different casing on the driver letter. Also here's the issue I opened on vscode about that for more context microsoft/vscode#40057 |
|
@hansonw Did a quick investigation and the problem happens here https://github.com/flowtype/flow-language-server/blob/master/src/Diagnostics.js#L78 when we create the URI. We could use https://github.com/flowtype/flow-language-server/blob/master/src/utils/util.js#L40 and patch it for windows but creating a uri object is more complex (It seems like we use only toString() so we could juste change the util method to return a string instead of the full uri object). Another alternative that might be better is to fork or vendor in vscode-uri and remove the code that lower cases driver letters. |
|
Thanks again, @janicduplessis! I've pushed a new flow-language-server version and ide-flowtype version so hopefully this should be fixed now. |
|
@hansonw @janicduplessis "Current File Only" now works on Windows! |
|
I'm still seeing this problem on Windows, when I open a file I see this. Tried re-installing the package and it didn't help. |
|
@sguergachi That's a separate issue (the outline was actually the only thing that did work on Windows!), there are a few issues already filed here about this but unfortunately I don't remember the solution off the top of my head. |
|
I still can't make it work. I tried to reinstall everything (even the Atom itself) and still got no flow error message, nor autocomplete, hints, etc. The Outline working just fine though
Did i missing something? Also i don't get any message in the console (from Ctrl+Shift+I), probably the ide didn't fire properly? |
|
@iamN00B The debug messages shown above are a hidden setting, if you want to enable them you need to type Does |
|
CLI runs fine and shows the error. Some errors do show up though after i enabled
|
|
@iamN00B using flow-bin from node_modules is not enabled by default. Go
into ide-flowtype's settings and enable "Use flow-bin from node_modules
when available" to see if that works for you.
…On Fri, Feb 2, 2018 at 10:35 AM, Landon Abney ***@***.***> wrote:
@iamN00B <https://github.com/iamn00b> The debug messages shown above are
a hidden setting, if you want to enable them you need to type
atom.config.set('core.debugLSP', true) in the console.
Does flow work in the CLI for you? (npx flow check)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#42 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAjPYle7lTLpOvKC0Rp9hTZb-tvh73GDks5tQ1V6gaJpZM4QflB8>
.
|
|
Looks like that's already enabled, and their |
|
@Arcanemagus @hansonw yep, it's enabled. Disable it doesn't help though. I see, i'll file this as a separate issue. thanks |
|
Seeing the same issue, (no diagnostics) though I don't see an error with code 12: |
|
@sguergachi Your screenshot shows diagnostics being pushed back for two files, so your problem is in the interface somewhere. |
|
@Arcanemagus Interface meaning ide-flowtype package or atom-ide package? |
|
|
I'm filing this to have a single place to track getting support for Windows here, as I don't see an issue specifically about this already filed.
@wbinnssmith Previously mentioned that there are a "few issues" in #17 (comment) and updated the readme to reflect that it wasn't "fully supported" after #10 (comment).
If there is anything you need help testing please let me know!
The text was updated successfully, but these errors were encountered: