This repository was archived by the owner on Jul 10, 2025. It is now read-only.
Particle lifecycle #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alari
reviewed
Feb 18, 2021
src/index.ts
Outdated
| @@ -18,7 +18,7 @@ export { seedToPeerId, peerIdToSeed, generatePeerId } from './internal/peerIdUti | |||
| export { FluenceClient } from './FluenceClient'; | |||
| export { SecurityTetraplet, PeerIdB58 } from './internal/commonTypes'; | |||
| export * from './api'; | |||
| export { Particle } from './internal/particle'; | |||
| export { RequestFlow as Particle } from './internal/particle'; | |||
coder11
force-pushed
the
particle-lifecycle
branch
from
e6826ab to
4292c24
Compare
DieMyst
reviewed
Mar 1, 2021
| @@ -86,7 +71,7 @@ describe('Builtins usage suite', () => { | |||
|
|
|||
| // FIXME:: there is no error on broken blueprint from a node | |||
| it.skip('create_service', async function () { | |||
There was a problem hiding this comment.
fix and unskip this test
also add test with real service creation
There was a problem hiding this comment.
let's add the new test during a separate issue
DieMyst
reviewed
Mar 1, 2021
| }); | ||
| }); | ||
|
|
||
| it('Should work with overlapping function registration', () => { |
There was a problem hiding this comment.
let's add in API somewhere a comment, that last registered function wins
DieMyst
reviewed
Mar 1, 2021
| import log from 'loglevel'; | ||
| import PeerId from 'peer-id'; | ||
| import { PeerIdB58, SecurityTetraplet } from './internal/commonTypes'; | ||
| import * as unstable from './api.unstable'; |
There was a problem hiding this comment.
maybe rename unstable as new? or some other positive term
There was a problem hiding this comment.
I think unstable conveys the message better
DieMyst
reviewed
Mar 1, 2021
DieMyst
reviewed
Mar 1, 2021
DieMyst
reviewed
Mar 1, 2021
src/internal/AquaHandler.ts
Outdated
| @@ -0,0 +1,127 @@ | |||
| import { CallServiceResult, ErrorCodes } from './commonTypes'; | |||
There was a problem hiding this comment.
docs on everything in this file
| )`; | ||
| }; | ||
|
|
||
| export class RequestFlowBuilder { |
src/internal/RequestFlowBuilder.ts
Outdated
| const msg = JSON.parse(args[0]); | ||
| res.raiseError(msg); | ||
| } catch (e) { | ||
| log.warn("Error handling script didn't work", e); |
There was a problem hiding this comment.
if JSON.parse throws an error should we raise an error too?
folex
approved these changes
Mar 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.