Skip to content

Conversation

sigJoe
Copy link
Contributor

@sigJoe sigJoe commented May 22, 2024

PR as suggested by @patrick-stephens in fluent/fluent-bit#8842, plus a few extra changes while I was at it.

  • Remove reference to mode: tls that no longer exists
  • Add reference to TLS/SSL config (copied from HTTP output plugin)
  • Added tabbed fluent-bit.yaml configuration examples (I don't have something that supports tab previews, but again I copied the syntax from HTTP)
  • Added config example with Lua function for populating structured data auth tokens for Loggly, Papertrail, etc.

@sigJoe sigJoe requested review from a team as code owners May 22, 2024 17:58
@patrick-stephens
Copy link
Contributor

Can you fix the DCO as we must have that for merge?

sigJoe added 5 commits May 24, 2024 09:42
Signed-off-by: Joe Wakefield <jwakefield@signiant.com>
Signed-off-by: Joe Wakefield <jwakefield@signiant.com>
Signed-off-by: Joe Wakefield <jwakefield@signiant.com>
Signed-off-by: Joe Wakefield <jwakefield@signiant.com>
Signed-off-by: Joe Wakefield <jwakefield@signiant.com>
@sigJoe
Copy link
Contributor Author

sigJoe commented May 24, 2024

Now rebased with signoff in the commits

Copy link
Contributor

@patrick-stephens patrick-stephens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a nitpick but could you split the sentences on to separate lines?
Github only lets you comment on a line so having lots of sentences on one makes it harder.

Signed-off-by: Joe Wakefield <jwakefield@signiant.com>
@sigJoe
Copy link
Contributor Author

sigJoe commented May 27, 2024

Sentences have been split

@patrick-stephens patrick-stephens merged commit 36db058 into fluent:master May 28, 2024
@sigJoe sigJoe deleted the syslog-updates branch May 28, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants