Async send #56
Merged
Async send #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: alexlry <alexandre@keymantics.com>
…n asynchronous mode - Configuration AsyncConnect is now named Async. - Errors during reconnect no longer cause panic. - Synchronous mode is now always synchronous (reconnect synchronously). Signed-off-by: alexlry <alexandre@keymantics.com>
alexlry
force-pushed
the
features/v1.3.0-async-send
branch
from
e2bd9fe to
3c0ef01
Compare
…8 and fixext 8. Signed-off-by: alexlry <alexandre@keymantics.com>
alexlry
force-pushed
the
features/v1.3.0-async-send
branch
from
27ac125 to
bea58e6
Compare
Closed
tagomoris
reviewed
Apr 17, 2018
fluent/fluent.go
Outdated
| } | ||
| } | ||
| return err | ||
|
|
||
| return errors.New("fluent#write: failed to reconnect") |
There was a problem hiding this comment.
How about to show that it's after retries, with MaxRetry value?
| @@ -89,11 +93,21 @@ func New(config Config) (f *Fluent, err error) { | |||
| if config.MaxRetry == 0 { | |||
| config.MaxRetry = defaultMaxRetry | |||
| } | |||
| if config.MaxRetryWait == 0 { | |||
| config.MaxRetryWait = defaultMaxRetryWait | |||
There was a problem hiding this comment.
Is it common thing to show messages about deprecation on os.Stderr here?
|
I'm very positive to merge this change. |
Signed-off-by: alexlry <alexandre@keymantics.com>
alexlry
force-pushed
the
features/v1.3.0-async-send
branch
from
291216a to
7d967ba
Compare
|
Thank you for your time reviewing these changes! I integrated your comments in last commit. |
|
I'll merge this change 12hours later unless any objections come here. |
|
Merged. Thank you! |
This was referenced Apr 16, 2019
thaJeztah
added a commit
to thaJeztah/cli
that referenced
this pull request
Apr 10, 2022
This option was deperecated in the upstream fluentd logging driver v1.4.0, and while we documented it as deprecated in the API changelog, there was no mention yet in the deprecated docs. relates to: - fluent/fluent-logger-golang#56 - moby/moby#39086 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added a commit
to thaJeztah/cli
that referenced
this pull request
Apr 10, 2022
This option was deperecated in the upstream fluentd logging driver v1.4.0, and while we documented it as deprecated in the API changelog, there was no mention yet in the deprecated docs. relates to: - fluent/fluent-logger-golang#56 - moby/moby#39086 Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 95b0c43) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is basically #52 without breaking changes.
We are using fluent logging in performance critical services and want to ensure fluent request can't impact service response time.
Noticeable changes in behavior are:
Should fix #33, #54