Skip to content

Add proper handling of the send, tracking if data was actually sent in #77 #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 6, 2017
Merged

Add proper handling of the send, tracking if data was actually sent in #77 #104

merged 3 commits into from
Dec 6, 2017

Conversation

arcivanov
Copy link
Member

Use TCP_NODELAY to detect disconnect early
Fix connection shutdown cleanup in #103
Make locking less verbose via with idiom

fixes #77, #103

@arcivanov
Copy link
Member Author

@dkalashnik please review

@coveralls
Copy link

coveralls commented Dec 4, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-1.4%) to 89.971% when pulling 083d3c5 on arcivanov:issue_77_103 into af4fd66 on fluent:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 91.176% when pulling 7749097 on arcivanov:issue_77_103 into af4fd66 on fluent:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 91.176% when pulling 7749097 on arcivanov:issue_77_103 into af4fd66 on fluent:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 91.176% when pulling 7749097 on arcivanov:issue_77_103 into af4fd66 on fluent:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 91.176% when pulling 7749097 on arcivanov:issue_77_103 into af4fd66 on fluent:master.

@arcivanov
Add proper handling of the send, tracking if data was actually sent in …
161d76e 
…fluent#77

Use TCP_NODELAY to detect disconnect early
Fix connection shutdown cleanup in fluent#103
Make locking less verbose via with idiom

fixes fluent#77, fluent#103
@coveralls
Copy link

coveralls commented Dec 4, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.3%) to 91.049% when pulling 161d76e on arcivanov:issue_77_103 into af4fd66 on fluent:master.

dkalashnik
dkalashnik approved these changes Dec 5, 2017
View reviewed changes
Copy link

@dkalashnik dkalashnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, works for me

@arcivanov
Copy link
Member Author

@repeatedly can you please take a look and merge?

@coveralls
Copy link

coveralls commented Dec 6, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.3%) to 92.795% when pulling 03946f0 on arcivanov:issue_77_103 into 3178185 on fluent:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 92.795% when pulling 03946f0 on arcivanov:issue_77_103 into 3178185 on fluent:master.

@repeatedly repeatedly merged commit 4a663c6 into fluent:master Dec 6, 2017
@repeatedly
Copy link
Member

Thanks!

@repeatedly
Copy link
Member

Release 0.7.0.

@arcivanov arcivanov mentioned this pull request Dec 6, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dkalashnik dkalashnik dkalashnik approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Events not delivered when connection is dropped

4 participants

@arcivanov @coveralls @repeatedly @dkalashnik