Skip to content

Fix concetion pool & timeout (issues #82) #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 20, 2020

Conversation

zamanimehdi
Copy link
Contributor

@zamanimehdi zamanimehdi commented Apr 6, 2020

ref: #82

This change was made to fix the servant's problem in clickhouse database.

Signed-off-by: zamani <zamani.mehdi@gmail.com>
Signed-off-by: zamani <zamani.mehdi@gmail.com>
Signed-off-by: zamani <zamani.mehdi@gmail.com>
@ganmacs
Copy link
Member

ganmacs commented Apr 7, 2020

Commits about #80 are included.

@repeatedly
Copy link
Member

pool and timeout default values are same with ActiveRecord?

@zamanimehdi
Copy link
Contributor Author

pool and timeout default values are same with ActiveRecord?

In non-parallel applications, requests sent via activerecord do not require a large amount of parallel request and connection pool, while in fluentd parallel transmissions , the amount of connection pool must be able to cover the number of simultaneous requests.
Therefore, activerecord connection pools must be greater than parallel fluentd threads.
On the other hand, according to bulk-insert, the value of timeout should be more than the usual requests.
The default values are set based on my own experience of working with fluentd.

@repeatedly repeatedly merged commit 003b986 into fluent:master Apr 20, 2020
@repeatedly
Copy link
Member

repeatedly commented Apr 20, 2020

Thanks. This patch will be included since v2.0.0.

repeatedly added a commit that referenced this pull request Apr 20, 2020
@zamanimehdi zamanimehdi deleted the fix-concetion-pool-&-timeout branch May 1, 2020 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants