Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for FluentAssertions v6.0. #25

Merged

Conversation

CNBoland
Copy link

In v6.0, class FluentAssertions.Common.ObjectExtensions was scoped internal. This was a breaking change to code that uses IsSameOrEqualTo() method. In a discussion here the author suggests to use object.Equals() instead.

This commit is incompatible with FluentAssertions v5.x due to breaking changes in FluentAssertions base classes. We probably need a new major version of FluentAssertions.AspNetCore.Mvc package.

Craig Boland added 2 commits August 16, 2021 14:54
In v6.0, class FluentAssertions.Common.ObjectExtensions was scoped internal. This was a breaking change to code that uses IsSameOrEqualTo() method. In a discussion here (fluentassertions/fluentassertions#1644 (comment)) the author suggests to use object.Equals() instead.
@faddiv faddiv merged commit 7494e0e into fluentassertions:master Aug 18, 2021
@faddiv
Copy link
Collaborator

faddiv commented Aug 18, 2021

Thank you for your contribution.

@CNBoland CNBoland deleted the Support_FluentAssertions_v6.0 branch August 18, 2021 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants