Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WithOffset helper extension method #1235

Merged
merged 4 commits into from Jan 20, 2020

Conversation

krajek
Copy link
Contributor

@krajek krajek commented Jan 12, 2020

Closes #1192.

Nothing special, simple wrapper, feels more fluent than existing ToDateTimeOffset.

@dennisdoomen
Copy link
Member

We merged some big changes to develop. Please rebase.

@jnyrup don't forget to review

# Conflicts:
#	Tests/Approval.Tests/ApprovedApi/FluentAssertions/net45.approved.txt
#	Tests/Approval.Tests/ApprovedApi/FluentAssertions/netstandard1.3.approved.txt
#	Tests/Approval.Tests/ApprovedApi/FluentAssertions/netstandard1.6.approved.txt
#	docs/_pages/releases.md
@krajek
Copy link
Contributor Author

krajek commented Jan 20, 2020

Rebase done.

@jnyrup
Copy link
Member

jnyrup commented Jan 20, 2020

We dropped net45, netstandard1.3 and netstandard1.3 in #1227.
So they corresponding approved.txt files should not be re-added :)

@krajek
Copy link
Contributor Author

krajek commented Jan 20, 2020

@jnyrup thanks, done. I enjoy merging so much I wanted the process to last as long as possible 😂 .

@jnyrup jnyrup merged commit e1ed198 into fluentassertions:develop Jan 20, 2020
@krajek krajek deleted the date_time_offset branch January 20, 2020 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request for DateTime extension method to produce DateTimeOffset
3 participants