Make pysane Python3-compatible #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
String exceptions are no longer supported in Python 3, so you need to do this too:
|
| /* Create the module and add the functions */ | ||
| PyObject *m = Py_InitModule("_sane", PySane_methods); | ||
| if(!m) | ||
| return; |
There was a problem hiding this comment.
That section of the code is for the python2 variant, where the module init function is void.
|
This was cherry-picked. (Which I now realize was the wrong thing to do, but the damage is done.) |
|
Uhm, I actually had a patch ready with the suggested modifications (but can't commit it until this evening being behind an annoying corporate firewall atm). Should I post a new pull-request? |
|
Oh, you already made the changes. Ok, never mind - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes allow the pysane module to be compiled both as a python2 or python3 module.