Skip to content

Fix some error #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 2, 2023
Merged

Fix some error #167

merged 3 commits into from
Apr 2, 2023

Conversation

ryojiro
Copy link
Contributor

@ryojiro ryojiro commented Apr 2, 2023

I just forked this repo to read this library and fixed some error.

  • Fix imports
  • Use double quotation instead of single in pubspec
  • Remove unnecessary null check, which never become null

cloudwebrtc
cloudwebrtc approved these changes Apr 2, 2023
View reviewed changes
Copy link
Member

@cloudwebrtc cloudwebrtc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg!

@cloudwebrtc cloudwebrtc merged commit f66bba5 into flutter-webrtc:master Apr 2, 2023
@ryojiro ryojiro deleted the fix_some_error branch April 2, 2023 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cloudwebrtc cloudwebrtc cloudwebrtc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryojiro @cloudwebrtc