New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move shared code out of `devtools_app` and `dds` into `devtools_shared` #3571

Closed

bkonyi opened this issue Jan 18, 2022 · 0 comments

Assignees

Labels

Contributor

bkonyi commented Jan 18, 2022

In particular, we'll want to move the following files / methods:

pkg/dds/lib/src/devtools/service_registrations.dart
normalizeVmServiceUri helper function

The text was updated successfully, but these errors were encountered:

bkonyi added the tech debt label

bkonyi assigned kenzieschmoll

kenzieschmoll mentioned this issue

Move shared code into devtools_shared #3827

Merged

kenzieschmoll closed this as completed

copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue


          Remove duplicated devtools_shared code from dds.

2e895ad

Fixes flutter/devtools#3571.

Change-Id: I168b44ef0e59a16695ce824499dff774ba46f3d1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239800
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Kenzie Davisson <kenzieschmoll@google.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment