Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevToolsExtensionConfig doc updates and breaking changes. #7570

Merged
merged 9 commits into from
Apr 16, 2024

Conversation

kenzieschmoll
Copy link
Member

@kenzieschmoll kenzieschmoll commented Apr 11, 2024

This fixes an issue where we were not properly validating the materialIconCodePoint field in the extension config.yaml file. Fixes #7393.

This PR also makes some documentation updates and does some naming cleanup since we will be making a series of breaking changes to support static devtools extensions anyway: #7569.

@kenzieschmoll kenzieschmoll requested a review from a team as a code owner April 11, 2024 23:15
@kenzieschmoll kenzieschmoll requested review from polina-c and removed request for a team April 11, 2024 23:15
@kenzieschmoll kenzieschmoll requested review from bkonyi and removed request for polina-c April 11, 2024 23:16
Copy link
Contributor

@bkonyi bkonyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits

@kenzieschmoll kenzieschmoll merged commit 85c48cc into flutter:master Apr 16, 2024
23 checks passed
@kenzieschmoll kenzieschmoll deleted the dte-static branch April 16, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

devtools_extensions validate command does not fail when 'materialIconCodePoint' key is invalid
2 participants