Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show all DevTools pages in the sidebar #7947

Merged
merged 21 commits into from
Jun 25, 2024

Conversation

kenzieschmoll
Copy link
Member

@kenzieschmoll kenzieschmoll commented Jun 18, 2024

Work towards #7946.

Screenshot 2024-06-18 at 3 50 01 PM

This uses an adaptive layout so that the tools are condensed to a single column when the sidebar is very narrow. When no debug sessions are available, the DevTools tool is grayed out with a tooltip explaining why.
sidebar-no-debug-sessionsScreenshot 2024-06-21 at 1 32 21 PM

@kenzieschmoll kenzieschmoll marked this pull request as ready for review June 21, 2024 20:27
@kenzieschmoll kenzieschmoll requested a review from a team as a code owner June 21, 2024 20:27
@kenzieschmoll kenzieschmoll requested review from CoderDake and removed request for a team June 21, 2024 20:27
@kenzieschmoll
Copy link
Member Author

@DanTup this is ready for review.

Copy link
Contributor

@DanTup DanTup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@DanTup DanTup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still lgtm! (few very minor comments you're free to ignore)

@kenzieschmoll kenzieschmoll merged commit e784023 into flutter:master Jun 25, 2024
23 checks passed
@kenzieschmoll kenzieschmoll deleted the sidebar-devtools branch June 25, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants