update to package:web 0.5.1 #7956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -80,7 +80,7 @@ class EmbeddedExtensionControllerImpl extends EmbeddedExtensionController | |||
| ); | |||
| _initialized = true; | |||
|
|
|||
| _extensionIFrame = createIFrameElement() | |||
| _extensionIFrame = HTMLIFrameElement() | |||
There was a problem hiding this comment.
is this equivalent to what createIFrameElement used to return? If so, LGTM.
There was a problem hiding this comment.
Yup! createIFrameElement() is now deprecated in favor of the HTMLIFrameElement() constructor.
| @@ -61,7 +61,7 @@ dependencies: | |||
| vm_service_protos: ^1.0.0 | |||
| # TODO https://github.com/dart-lang/sdk/issues/52853 - unpin this version | |||
| vm_snapshot_analysis: ^0.7.6 | |||
| web: ^0.4.1 | |||
| web: ^0.5.0 | |||
There was a problem hiding this comment.
should these versions be 0.5.1?
There was a problem hiding this comment.
I tend to just specify the version required (here, 0.5.0 for the new API) rather than the latest bug fix version. Happy to be more specific here if desired.
kenzieschmoll
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates to the latest published version of
package:web, and works around anunnecessary_castissue (https://github.com/flutter/devtools/compare/upgrade_package_web?expand=1#diff-8b45cb7b869f9836b4133c64a40f7d30a672febc77188e247035adcc23951763R42) that we'd otherwise hit in the next toll to google3.Pre-launch Checklist
///).If you need help, consider asking for help on Discord.