Show a screen unavailable message for disabled screens. #7958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanTup
approved these changes
Jun 21, 2024
Comment on lines
+510
to
+512
| } else if (reason?.message != null) { | ||
| disabledReason = 'The ${screen.title} screen ${reason!.message!}'; | ||
| } |
There was a problem hiding this comment.
Not important, but FWIW using case String is a nice way to avoid the !s here:
if (reason?.message case String message) {
disabledReason = 'The ${screen.title} screen $message';
}There was a problem hiding this comment.
Nice! will add to a follow up PR.
There was a problem hiding this comment.
Oh and you can avoid writing the type (String) again like this:
if (reason?.message case final message?) {
CoderDake
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a first party DevTools screen is loaded but is not available for the current app, we now show a message explaining why. Before we just silently navigated to a different screen or showed a blank page when embedded.
Now, we show this:
Embedded mode (hide the navigate home button in this case):
Fixes #7879