Switch to FilterQuality.medium for images (#52984)

flutter/flutter#148253
flutter · May 29, 2024 · 557a4c6 · 557a4c6
1 parent fc3ae2d
commit 557a4c6
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 2 deletions.
diff --git a/lib/ui/painting.dart b/lib/ui/painting.dart
@@ -3740,7 +3740,7 @@ abstract class ImageFilter {
   /// For example, applying a positive scale matrix (see [Matrix4.diagonal3])
   /// when used with [BackdropFilter] would magnify the background image.
   factory ImageFilter.matrix(Float64List matrix4,
-                     { FilterQuality filterQuality = FilterQuality.low }) {
+                     { FilterQuality filterQuality = FilterQuality.medium }) {
     if (matrix4.length != 16) {
       throw ArgumentError('"matrix4" must have 16 entries.');
     }

diff --git a/lib/web_ui/lib/painting.dart b/lib/web_ui/lib/painting.dart
@@ -439,7 +439,7 @@ class ImageFilter {
   factory ImageFilter.erode({ double radiusX = 0.0, double radiusY = 0.0 }) =>
     engine.renderer.createErodeImageFilter(radiusX: radiusX, radiusY: radiusY);
 
-  factory ImageFilter.matrix(Float64List matrix4, {FilterQuality filterQuality = FilterQuality.low}) {
+  factory ImageFilter.matrix(Float64List matrix4, {FilterQuality filterQuality = FilterQuality.medium}) {
     if (matrix4.length != 16) {
       throw ArgumentError('"matrix4" must have 16 entries.');
     }

diff --git a/testing/dart/painting_test.dart b/testing/dart/painting_test.dart
@@ -6,6 +6,7 @@ import 'dart:typed_data';
 import 'dart:ui';
 
 import 'package:litetest/litetest.dart';
+import 'package:vector_math/vector_math_64.dart';
 
 typedef CanvasCallback = void Function(Canvas canvas);
 
@@ -103,4 +104,12 @@ void main() {
     whitePicture.dispose();
     redClippedPicture.dispose();
   });
+
+  test('ImageFilter.matrix defaults to FilterQuality.medium', () {
+    final Float64List data = Matrix4.identity().storage;
+    expect(
+      ImageFilter.matrix(data).toString(),
+      'ImageFilter.matrix($data, FilterQuality.medium)',
+    );
+  });
 }