Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Revert "Reland "add non-rendering operation culling to DisplayListBui…
…lder" (#41463)" (#43721) Reverts #43698 A framework tree test started failing on the engine roll with this PR: flutter/flutter#130643 The test failure is in https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_android%20hybrid_android_views_integration_test/8517/overview ``` [2023-07-14 19:33:21.980926] [STDOUT] stdout: [ +6 ms] I/PlatformViewsController( 9988): Using hybrid composition for platform view: 5 [2023-07-14 19:33:22.767236] [STDOUT] stdout: [ +786 ms] 00:19 �[32m+4�[0m�[31m -1�[0m: Flutter surface with hybrid composition Uses FlutterImageView when Android view is on the screen �[1m�[31m[E]�[0m�[0m [2023-07-14 19:33:22.767765] [STDOUT] stdout: [ ] Expected: '|-FlutterView\n' [2023-07-14 19:33:22.767815] [STDOUT] stdout: [ ] ' |-FlutterSurfaceView\n' [2023-07-14 19:33:22.767924] [STDOUT] stdout: [ ] ' |-FlutterImageView\n' [2023-07-14 19:33:22.768084] [STDOUT] stdout: [ ] ' |-ViewGroup\n' [2023-07-14 19:33:22.768162] [STDOUT] stdout: [ ] ' |-ViewGroup\n' [2023-07-14 19:33:22.768800] [STDOUT] stdout: [ ] ' |-FlutterImageView\n' [2023-07-14 19:33:22.768835] [STDOUT] stdout: [ ] '' [2023-07-14 19:33:22.768853] [STDOUT] stdout: [ ] Actual: '|-FlutterView\n' [2023-07-14 19:33:22.768882] [STDOUT] stdout: [ ] ' |-FlutterSurfaceView\n' [2023-07-14 19:33:22.768900] [STDOUT] stdout: [ ] ' |-FlutterImageView\n' [2023-07-14 19:33:22.768917] [STDOUT] stdout: [ ] ' |-ViewGroup\n' [2023-07-14 19:33:22.768956] [STDOUT] stdout: [ ] ' |-ViewGroup\n' [2023-07-14 19:33:22.769119] [STDOUT] stdout: [ ] '' [2023-07-14 19:33:22.769156] [STDOUT] stdout: [ ] Which: is different. Both strings start the same, but the actual value is missing the following trailing characters: |-Flutte ... [2023-07-14 19:33:22.779280] [STDOUT] stdout: [ +10 ms] package:matcher/src/expect/expect.dart 149:31 fail [2023-07-14 19:33:22.779326] [STDOUT] stdout: [ ] package:matcher/src/expect/expect.dart 144:3 _expect [2023-07-14 19:33:22.780315] [STDOUT] stdout: [ ] package:matcher/src/expect/expect.dart 56:3 expect [2023-07-14 19:33:22.780345] [STDOUT] stdout: [ ] test_driver/main_test.dart 124:7 main.<fn>.<fn> [2023-07-14 19:33:22.780356] [STDOUT] stdout: [ ] ===== asynchronous gap =========================== [2023-07-14 19:33:22.780365] [STDOUT] stdout: [ ] package:test_api/src/backend/declarer.dart 215:9 Declarer.test.<fn>.<fn> [2023-07-14 19:33:22.780376] [STDOUT] stdout: [ ] ===== asynchronous gap =========================== [2023-07-14 19:33:22.780385] [STDOUT] stdout: [ ] package:test_api/src/backend/declarer.dart 213:7 Declarer.test.<fn> [2023-07-14 19:33:22.780395] [STDOUT] stdout: [ ] ===== asynchronous gap =========================== [2023-07-14 19:33:22.780405] [STDOUT] stdout: [ ] package:test_api/src/backend/invoker.dart 258:9 Invoker._waitForOutstandingCallbacks.<fn> [2023-07-14 19:33:22.780415] [STDOUT] stdout: [ ] 00:19 �[32m+4�[0m�[31m -1�[0m: Flutter surface with hybrid composition (tearDownAll)�[0m [2023-07-14 19:33:22.907295] [STDOUT] stdout: [ +126 ms] 00:19 �[32m+4�[0m�[31m -1�[0m: (tearDownAll)�[0m [2023-07-14 19:33:22.947855] [STDOUT] stdout: [ +41 ms] 00:19 �[32m+4�[0m�[31m -1�[0m: �[31mSome tests failed.�[0m ``` This change in that roll looks like it may be related.
- Loading branch information