Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Test profile and release build and unit tests #7880

Merged
merged 4 commits into from
Feb 21, 2019
Merged

Test profile and release build and unit tests #7880

merged 4 commits into from
Feb 21, 2019

Conversation

dnfield
Copy link
Contributor

@dnfield dnfield commented Feb 20, 2019

This would have caught the problem caused by 3a1b9b3

@dnfield
Copy link
Contributor Author

dnfield commented Feb 20, 2019

@chinmaygarde I've made a couple more changes here - rolling us to latest googletest so I can use GTEST_SKIP, and skipping the dart_isolate tests that involve things that don't seem to work in profile or release. I'm a little confused there - I would have expected the Dart VM to tell us it's in AOT mode in these cases, but it doesn't. I suspect that's because these are host builds, which don't support AOT right now. But if that's the case, I'm no longer as sure about why the JIT related tests are failing for profile/release - I'm assuming that something's just not wired right in that case.

@dnfield dnfield force-pushed the test_profile branch 3 times, most recently from 66801b1 to d0893c7 Compare February 21, 2019 03:52
@dnfield dnfield merged commit 39f7066 into flutter:master Feb 21, 2019
@dnfield dnfield deleted the test_profile branch February 21, 2019 04:13
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 21, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 21, 2019
@engine-flutter-autoroll
39f7066 Test profile and release build and unit tests (flutter/engine…
920ca22 
…#7880)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 21, 2019
@engine-flutter-autoroll
39f7066 Test profile and release build and unit tests (flutter/engine…
e578a90 
…#7880)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 21, 2019
Closed
@cbracken cbracken mentioned this pull request Feb 21, 2019
Closed
cbracken added a commit to cbracken/flutter that referenced this pull request Feb 21, 2019
@cbracken
Roll engine to 293b3de
27f986c 
flutter/engine@293b3de98 Roll src/third_party/skia 20ebd0cb3882..348227b89430 (4 commits) (flutter/engine#7900)
flutter/engine@6e6020d29 Eliminate .member = foo struct initialization (flutter/engine#7899)
flutter/engine@6d8bd99af Revert "Reland PerformanceOverlayLayer golden test (flutter/engine#7863)" (flutter#7895)
flutter/engine@39f7066b6 Test profile and release build and unit tests (flutter/engine#7880)
flutter/engine@abe9826a9 Add accessibility semantics support to embedder (flutter/engine#7891)
flutter/engine@ce7016e1f Roll src/third_party/skia e471c05f92e8..20ebd0cb3882 (4 commits) (flutter/engine#7894)
flutter/engine@684c9394c Respect the custom GL proc table when creating the resource context on the IO thread. (flutter/engine#7893)
flutter/engine@e11d0e96f Android embedding refactor pr5 add flutterengine impl (flutter/engine#7878)
flutter/engine@2f4a38dbd Android embedding refactor pr3 add remaining systemchannels (flutter/engine#7892)
flutter/engine@8427d73c8 Reland PerformanceOverlayLayer golden test (flutter/engine#7863)
flutter/engine@61fc1786f Roll src/third_party/dart c92d5ca288..5ddd157809 (153 commits)
flutter/engine@b0671145a Roll src/third_party/skia 7738736f9622..e471c05f92e8 (23 commits) (flutter/engine#7889)
flutter/engine@6d7eb5218 Revert "Android embedding refactor pr3 add remaining systemchannels (flutter/engine#7874)" (flutter#7886)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 21, 2019
@engine-flutter-autoroll
39f7066 Test profile and release build and unit tests (flutter/engine…
1bc0479 
…#7880)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 21, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 21, 2019
@engine-flutter-autoroll
39f7066 Test profile and release build and unit tests (flutter/engine…
7463073 
…#7880)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 21, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 21, 2019
@engine-flutter-autoroll
39f7066 Test profile and release build and unit tests (flutter/engine…
576300b 
…#7880)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 21, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 21, 2019
@engine-flutter-autoroll
39f7066 Test profile and release build and unit tests (flutter/engine…
6f964a0 
…#7880)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 21, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 22, 2019
@engine-flutter-autoroll
39f7066 Test profile and release build and unit tests (flutter/engine…
0dceb5a 
…#7880)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2019
Closed
@cbracken cbracken mentioned this pull request Feb 22, 2019
Merged
cbracken added a commit to cbracken/flutter that referenced this pull request Feb 22, 2019
@cbracken
Roll the engine to 5db4b37
d2dac14 
flutter/engine@f1f19bba8 Revert "Revert "Revert "Reland PerformanceOverlayLayer golden test (flutter/engine#7863)" (flutter/engine#7895)" (flutter/engine#7911)" (flutter/engine#7916)
flutter/engine@5db4b3772 Revert dart rolls (flutter/engine#7913)
flutter/engine@0053c1d50 Roll src/third_party/dart 75ee523f91..4cff5a4fd6 (6 commits)
flutter/engine@8620579cf Roll src/third_party/skia 9a049e6ce39d..63c4d3596915 (8 commits) (flutter/engine#7909)
flutter/engine@aa2b287cb Reland flutter/engine#7777 with proper LICENSE (flutter/engine#7888)
flutter/engine@a5773d121 Do not add ghost runs for trailing whitespace if the text is ellipsized (flutter/engine#7906)
flutter/engine@93eeb48ba Revert "Revert "Remove unnecessary entry-point closurization. (flutter/engine#7827)" (flutter/engine#7876)" (flutter/engine#7904)
flutter/engine@bbaeba3f3 Roll src/third_party/skia 05ff93c43ea5..9a049e6ce39d (11 commits) (flutter/engine#7903)
flutter/engine@1cf6b8b64 Roll src/third_party/dart 5ddd157809..75ee523f91 (19 commits)
flutter/engine@be32040ef Roll src/third_party/skia 348227b89430..05ff93c43ea5 (2 commits) (flutter/engine#7901)
flutter/engine@293b3de98 Roll src/third_party/skia 20ebd0cb3882..348227b89430 (4 commits) (flutter/engine#7900)
flutter/engine@6e6020d29 Eliminate .member = foo struct initialization (flutter/engine#7899)
flutter/engine@6d8bd99af Revert "Reland PerformanceOverlayLayer golden test (flutter/engine#7863)" (flutter/engine#7895)
flutter/engine@39f7066b6 Test profile and release build and unit tests (flutter/engine#7880)
flutter/engine@abe9826a9 Add accessibility semantics support to embedder (flutter/engine#7891)
flutter/engine@ce7016e1f Roll src/third_party/skia e471c05f92e8..20ebd0cb3882 (4 commits) (flutter/engine#7894)
flutter/engine@684c9394c Respect the custom GL proc table when creating the resource context on the IO thread. (flutter/engine#7893)
flutter/engine@e11d0e96f Android embedding refactor pr5 add flutterengine impl (flutter/engine#7878)
flutter/engine@2f4a38dbd Android embedding refactor pr3 add remaining systemchannels (flutter/engine#7892)
flutter/engine@8427d73c8 Reland PerformanceOverlayLayer golden test (flutter/engine#7863)
flutter/engine@61fc1786f Roll src/third_party/dart c92d5ca288..5ddd157809 (153 commits)
flutter/engine@b0671145a Roll src/third_party/skia 7738736f9622..e471c05f92e8 (23 commits) (flutter/engine#7889)
flutter/engine@6d7eb5218 Revert "Android embedding refactor pr3 add remaining systemchannels (flutter/engine#7874)" (flutter/engine#7886)
flutter/engine@dad6ec01c Correct onAccessibilityFeaturesChanged docs (flutter/engine#7883)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 22, 2019
@engine-flutter-autoroll
39f7066 Test profile and release build and unit tests (flutter/engine…
1d53072 
…#7880)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 22, 2019
@engine-flutter-autoroll
39f7066 Test profile and release build and unit tests (flutter/engine…
8159424 
…#7880)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2019
Closed
cbracken added a commit to flutter/flutter that referenced this pull request Feb 22, 2019
@cbracken
Roll the engine to 5db4b37 (#28296)
007a415 
flutter/engine@f1f19bba8 Revert "Revert "Revert "Reland PerformanceOverlayLayer golden test (flutter/engine#7863)" (flutter/engine#7895)" (flutter/engine#7911)" (flutter/engine#7916)
flutter/engine@5db4b3772 Revert dart rolls (flutter/engine#7913)
flutter/engine@0053c1d50 Roll src/third_party/dart 75ee523f91..4cff5a4fd6 (6 commits)
flutter/engine@8620579cf Roll src/third_party/skia 9a049e6ce39d..63c4d3596915 (8 commits) (flutter/engine#7909)
flutter/engine@aa2b287cb Reland flutter/engine#7777 with proper LICENSE (flutter/engine#7888)
flutter/engine@a5773d121 Do not add ghost runs for trailing whitespace if the text is ellipsized (flutter/engine#7906)
flutter/engine@93eeb48ba Revert "Revert "Remove unnecessary entry-point closurization. (flutter/engine#7827)" (flutter/engine#7876)" (flutter/engine#7904)
flutter/engine@bbaeba3f3 Roll src/third_party/skia 05ff93c43ea5..9a049e6ce39d (11 commits) (flutter/engine#7903)
flutter/engine@1cf6b8b64 Roll src/third_party/dart 5ddd157809..75ee523f91 (19 commits)
flutter/engine@be32040ef Roll src/third_party/skia 348227b89430..05ff93c43ea5 (2 commits) (flutter/engine#7901)
flutter/engine@293b3de98 Roll src/third_party/skia 20ebd0cb3882..348227b89430 (4 commits) (flutter/engine#7900)
flutter/engine@6e6020d29 Eliminate .member = foo struct initialization (flutter/engine#7899)
flutter/engine@6d8bd99af Revert "Reland PerformanceOverlayLayer golden test (flutter/engine#7863)" (flutter/engine#7895)
flutter/engine@39f7066b6 Test profile and release build and unit tests (flutter/engine#7880)
flutter/engine@abe9826a9 Add accessibility semantics support to embedder (flutter/engine#7891)
flutter/engine@ce7016e1f Roll src/third_party/skia e471c05f92e8..20ebd0cb3882 (4 commits) (flutter/engine#7894)
flutter/engine@684c9394c Respect the custom GL proc table when creating the resource context on the IO thread. (flutter/engine#7893)
flutter/engine@e11d0e96f Android embedding refactor pr5 add flutterengine impl (flutter/engine#7878)
flutter/engine@2f4a38dbd Android embedding refactor pr3 add remaining systemchannels (flutter/engine#7892)
flutter/engine@8427d73c8 Reland PerformanceOverlayLayer golden test (flutter/engine#7863)
flutter/engine@61fc1786f Roll src/third_party/dart c92d5ca288..5ddd157809 (153 commits)
flutter/engine@b0671145a Roll src/third_party/skia 7738736f9622..e471c05f92e8 (23 commits) (flutter/engine#7889)
flutter/engine@6d7eb5218 Revert "Android embedding refactor pr3 add remaining systemchannels (flutter/engine#7874)" (flutter/engine#7886)
flutter/engine@dad6ec01c Correct onAccessibilityFeaturesChanged docs (flutter/engine#7883)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chinmaygarde chinmaygarde chinmaygarde approved these changes

@mklim mklim Awaiting requested review from mklim

@jason-simmons jason-simmons Awaiting requested review from jason-simmons

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dnfield @chinmaygarde @googlebot