Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Memory leak when using PlatformView [IOS] #24714 #7919

Merged
merged 1 commit into from
Feb 22, 2019

Conversation

ashawn
Copy link
Contributor

@ashawn ashawn commented Feb 22, 2019

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@ashawn
Copy link
Contributor Author

ashawn commented Feb 22, 2019

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@amirh
Copy link
Contributor

amirh commented Feb 22, 2019

Thanks!

Copy link
Contributor

@amirh amirh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amirh
Copy link
Contributor

amirh commented Feb 22, 2019

cc @chinmaygarde

@amirh
Copy link
Contributor

amirh commented Feb 22, 2019

Will land on green

@chinmaygarde
Copy link
Member

Good catch. Thanks. I wonder if we should provide a custom GL proc resolver with instrumented variants of the OpenGL methods where we can do sanity checks like this. There may be more instances of such leaks. CC @jason-simmons

engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Feb 22, 2019
flutter/engine@33bb91c...f80928a

git log 33bb91c..f80928a --no-merges --oneline
f80928a Roll src/third_party/skia fdd15284affe..ee1c8a733e5b (15 commits) (flutter/engine#7924)
93f339f fix Memory leak when using PlatformView [IOS] #24714 (flutter/engine#7919)
2d33e77 Roll src/third_party/skia 969659dbb313..fdd15284affe (2 commits) (flutter/engine#7922)
6d4edf2 Roll src/third_party/skia 9431161ca973..969659dbb313 (3 commits) (flutter/engine#7921)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (amirha@google.com), and stop
the roller if necessary.
@xujunquan
Copy link

xujunquan commented Jul 31, 2019

@chinmaygarde it is a big problem to me ,can you give me some help

https://github.com/flutter/flutter/issues/37225

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory leak when using PlatformView [IOS]
5 participants