Fixed an Android keyboard entry bug that was introduced by the embedding refactor. (#28438) #7954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthew-carroll
requested review from
dnfield,
gspencergoog,
jonahwilliams and
jason-simmons
jason-simmons
approved these changes
Feb 26, 2019
|
test? |
dnfield
approved these changes
Feb 26, 2019
|
@dnfield would you mind adding a device lab test? or would you like me to do it (I may need some assistance)? |
|
I can help! |
|
@jonahwilliams and I tried to write a test but ADB seems to behave differently than a host keyboard. We are merging this now without a test based on direct proof that the original ticket is fixed. We want to merge in before a major Dart roll. CC @bkonyi |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 26, 2019
…e embedding refactor. (flutter#28438) (flutter/engine#7954)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 26, 2019
…e embedding refactor. (flutter#28438) (flutter/engine#7954)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 26, 2019
…e embedding refactor. (flutter#28438) (flutter/engine#7954)
This was referenced Feb 26, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 26, 2019
…e embedding refactor. (flutter#28438) (flutter/engine#7954)
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Feb 26, 2019
flutter/engine@1d0615a...31d31e6 git log 1d0615a..31d31e6 --no-merges --oneline 31d31e6 Android PR 7: Introduce structure of FlutterActivity and FlutterFragment (flutter/engine#7912) 3962bbd Roll src/third_party/skia bcfbf6e94c22..ac6d4c0c8eae (1 commits) (flutter/engine#7958) cb9e673 Roll src/third_party/dart 7a63d31151..f7e435ac26 (252 commits) 18ad03d Fixed an Android keyboard entry bug that was introduced by the embedding refactor. (#28438) (flutter/engine#7954) a61056a Roll src/third_party/skia 0b2c05470bab..bcfbf6e94c22 (8 commits) (flutter/engine#7956) b36f903 Roll src/third_party/dart c92d5ca288..7a63d31151 (6 commits) (flutter/engine#7955) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (garyq@google.com), and stop the roller if necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Android embedding refactor inadvertently stopped storing the
mLastInputConnectioninFlutterView. That mistake broke certain types of text input.The chosen solution in this PR is to make
TextInputPlugina dependency ofAndroidKeyProcessorsuch thatAndroidKeyProcessorcan askTextInputPluginfor the lastInputConnectionand resurrect the behavior that was lost fromFlutterView.I have verified that this change resolves the specific emulator issue logged in the ticket. I have not verified with a physical keyboard.