Android Embedding PR 13: Integrated text input, keyevent input, and some other channel comms in FlutterView. #7979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ome other channel comms in FlutterView.
matthew-carroll
requested review from
goderbauer,
mklim,
jonahwilliams,
jason-simmons and
DaveShuckerow
dnfield
reviewed
Feb 28, 2019
shell/platform/android/io/flutter/embedding/engine/android/FlutterView.java
Show resolved
Hide resolved
dnfield
reviewed
Feb 28, 2019
|
LGTM |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 1, 2019
…t, and some other channel comms in FlutterView. (flutter/engine#7979)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 1, 2019
…t, and some other channel comms in FlutterView. (flutter/engine#7979)
cbracken
added a commit
to cbracken/flutter
that referenced
this pull request
Mar 1, 2019
flutter/engine@99f3f7a9c Fix incorrect transformation matrix (flutter/engine#8001) flutter/engine@c88b09710 Roll src/third_party/skia b7b2da871e95..255569187f27 (23 commits) (flutter/engine#8002) flutter/engine@302e2e9d2 Fix cursor jumping when typing some special characters. (flutter/engine#7964) flutter/engine@fe15149d1 Android Embedding PR 12: Add lifecycle methods to FlutterActivity. (flutter/engine#7974) flutter/engine@6145e9046 Android Embedding PR 13: Integrated text input, keyevent input, and some other channel comms in FlutterView. (flutter/engine#7979)
cbracken
added a commit
to flutter/flutter
that referenced
this pull request
Mar 1, 2019
flutter/engine@99f3f7a9c Fix incorrect transformation matrix (flutter/engine#8001) flutter/engine@c88b09710 Roll src/third_party/skia b7b2da871e95..255569187f27 (23 commits) (flutter/engine#8002) flutter/engine@302e2e9d2 Fix cursor jumping when typing some special characters. (flutter/engine#7964) flutter/engine@fe15149d1 Android Embedding PR 12: Add lifecycle methods to FlutterActivity. (flutter/engine#7974) flutter/engine@6145e9046 Android Embedding PR 13: Integrated text input, keyevent input, and some other channel comms in FlutterView. (flutter/engine#7979)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR frames out a number of important methods in
FlutterView, some of them are implemented in this PR, others are framed out for future work with associated comments.As a side effect, this PR changes old
FlutterViewreferences toViewreferences because those existing references were over-specialized.CC @goderbauer and @jonahwilliams to give visibility on the change from
FlutterViewtoViewin some input processing areas.