Issue 13238: on iOS, force an orientation change when the current orientation is not allowed #13170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…entation is not in the list of preferred orientations
josh-ksr
changed the title
gaaclarke
reviewed
Oct 16, 2019
| @@ -441,6 +441,7 @@ - (void)testWillDeallocNotification { | |||
| XCTestExpectation* expectation = | |||
| [[XCTestExpectation alloc] initWithDescription:@"notification called"]; | |||
| id engine = [[MockEngine alloc] init]; | |||
| @autoreleasepool { | |||
There was a problem hiding this comment.
I tried to reproduce the LUCI error locally, were you able to reproduce it?
There was a problem hiding this comment.
Yes, you need to run all unittests at once on iOS 12.2 simulator, does not happen with 13.0 or if you run just the single test
|
https://chromium-swarm.appspot.com/task?id=47ee8117695de810 . I launched a LUCI test for this, it works. LGTM |
gaaclarke
approved these changes
Oct 16, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 31, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Oct 31, 2019
git@github.com:flutter/engine.git/compare/4b76fadbf438...7c80d62 git log 4b76fad..7c80d62 --no-merges --oneline 2019-10-31 iska.kaushik@gmail.com CIPD needs the directory to be relative (flutter/engine#13461) 2019-10-31 1541038+josh-ksr@users.noreply.github.com Force orientation change when current orientation not allowed on iOS (flutter/engine#13170) 2019-10-31 jason-simmons@users.noreply.github.com Duplicate the directory fd in fml::VisitFiles (flutter/engine#13448) 2019-10-31 amirh@users.noreply.github.com Fix iOS crash when multiple platform views are in the scene (flutter/engine#13449) 2019-10-30 skia-flutter-autoroll@skia.org Roll src/third_party/skia 7df14d055703..549325c87e9d (11 commits) (flutter/engine#13447) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC cbracken@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Nov 26, 2019
git@github.com:flutter/engine.git/compare/4b76fadbf438...7c80d62 git log 4b76fad..7c80d62 --no-merges --oneline 2019-10-31 iska.kaushik@gmail.com CIPD needs the directory to be relative (flutter/engine#13461) 2019-10-31 1541038+josh-ksr@users.noreply.github.com Force orientation change when current orientation not allowed on iOS (flutter/engine#13170) 2019-10-31 jason-simmons@users.noreply.github.com Duplicate the directory fd in fml::VisitFiles (flutter/engine#13448) 2019-10-31 amirh@users.noreply.github.com Fix iOS crash when multiple platform views are in the scene (flutter/engine#13449) 2019-10-30 skia-flutter-autoroll@skia.org Roll src/third_party/skia 7df14d055703..549325c87e9d (11 commits) (flutter/engine#13447) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC cbracken@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next try as the merge was reverted.
There was a problem in another unittest (testWillDeallocNotification) together with the changes from this pull request. I fixed it with the last commit.
Fixes the iOS part of flutter/flutter#13238