Add ImageFilter and BackdropFilter to CanvasKit backend #13768

harryterkelsen · 2019-11-09T00:47:16Z

This shows how it looks with a Cupertino dialog (ignore ugly fonts):

nturgut · 2019-11-09T01:06:06Z

lib/web_ui/lib/src/engine/compositor/image_filter.dart

+// found in the LICENSE file.
+
+part of engine;
+


Can we add comments to the class?

nturgut · 2019-11-09T01:07:14Z

lib/web_ui/lib/src/ui/painting.dart

@@ -1055,7 +1055,7 @@ class Paint {
      _paintData = _paintData.clone();
      _frozen = false;
    }
-   _paintData.color = value.runtimeType == Color ? value : Color(value.value);
+    _paintData.color = value.runtimeType == Color ? value : Color(value.value);


nit: extra space

it was incorrectly indented before

nturgut · 2019-11-09T01:10:05Z

lib/web_ui/lib/src/engine/compositor/util.dart

+    skPaint.callMethod(
+        'setImageFilter', <js.JsObject>[skImageFilter.skImageFilter]);
+  }
+


question: does the order of method calls make a difference? If so may be we should document it.

Order doesn't matter

nturgut

Thanks Harry!

Only a few comments on documentation.

yjbanov · 2019-11-09T23:42:38Z

lib/web_ui/lib/src/engine/compositor/image_filter.dart

+  }
+
+  double get sigmaX => throw UnimplementedError(
+      'CanvasKit backend doesn\'t support ImageFilter.sigmaX');


We shouldn't have these in ui. Can you please move them under src/engine?

yjbanov · 2019-11-09T23:47:18Z

lib/web_ui/lib/src/engine/compositor/initialization.dart

@@ -9,7 +9,7 @@ const bool experimentalUseSkia =
    bool.fromEnvironment('FLUTTER_WEB_USE_SKIA', defaultValue: false);

 /// The URL to use when downloading the CanvasKit script and associated wasm.
-const String canvasKitBaseUrl = 'https://unpkg.com/canvaskit-wasm@0.7.0/bin/';
+const String canvasKitBaseUrl = 'https://particles.skia.org/static/';


Will this make our tests unstable? Maybe host our own copy on a firebase static site? This way we can control when to upload a new version.

There are currently no CanvasKit tests. We can worry about this when we enable testing for CanvasKit

Ah right, one more thing to add to our testing strategy :)

…ter/engine#13768)

harryterkelsen added 2 commits November 8, 2019 16:43

Implement ImageFilter.blur and BackdropFilter

a23e417

update licenses file

98ddc14

harryterkelsen requested review from yjbanov and nturgut November 9, 2019 00:47

googlebot added the cla: yes label Nov 9, 2019

Merge branch 'master' into canvaskit-imagefilter

d1a5122

nturgut reviewed Nov 9, 2019

View reviewed changes

nturgut approved these changes Nov 9, 2019

View reviewed changes

yjbanov approved these changes Nov 9, 2019

View reviewed changes

harryterkelsen added 2 commits November 11, 2019 16:36

Merge branch 'master' into canvaskit-imagefilter

7626ca5

Respond to review comments

902e507

harryterkelsen merged commit 63e8c62 into flutter:master Nov 12, 2019

engine-flutter-autoroll mentioned this pull request Nov 12, 2019

Roll engine 31cd2dfca22a..63e8c6275e4e (17 commits) flutter/flutter#44647

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2019

63e8c62 Add ImageFilter and BackdropFilter to CanvasKit backend (flut…

1d40406

…ter/engine#13768)

engine-flutter-autoroll mentioned this pull request Nov 12, 2019

Roll engine 31cd2dfca22a..63e8c6275e4e (17 commits) flutter/flutter#44649

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2019

63e8c62 Add ImageFilter and BackdropFilter to CanvasKit backend (flut…

cf9ff70

…ter/engine#13768)

engine-flutter-autoroll mentioned this pull request Nov 12, 2019

Roll engine 31cd2dfca22a..63e8c6275e4e (17 commits) flutter/flutter#44650

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2019

63e8c62 Add ImageFilter and BackdropFilter to CanvasKit backend (flut…

3224b3e

…ter/engine#13768)

engine-flutter-autoroll mentioned this pull request Nov 12, 2019

Roll engine 31cd2dfca22a..63e8c6275e4e (17 commits) flutter/flutter#44652

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2019

63e8c62 Add ImageFilter and BackdropFilter to CanvasKit backend (flut…

89d1e17

…ter/engine#13768)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2019

63e8c62 Add ImageFilter and BackdropFilter to CanvasKit backend (flut…

892ea42

…ter/engine#13768)

This was referenced Nov 12, 2019

Roll engine 31cd2dfca22a..63e8c6275e4e (17 commits) flutter/flutter#44654

Closed

Roll engine 31cd2dfca22a..63e8c6275e4e (17 commits) flutter/flutter#44656

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2019

63e8c62 Add ImageFilter and BackdropFilter to CanvasKit backend (flut…

4edcd3c

…ter/engine#13768)

engine-flutter-autoroll mentioned this pull request Nov 12, 2019

Roll engine 31cd2dfca22a..63e8c6275e4e (17 commits) flutter/flutter#44658

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2019

63e8c62 Add ImageFilter and BackdropFilter to CanvasKit backend (flut…

84fe640

…ter/engine#13768)

engine-flutter-autoroll mentioned this pull request Nov 12, 2019

Roll engine 31cd2dfca22a..63e8c6275e4e (17 commits) flutter/flutter#44659

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2019

63e8c62 Add ImageFilter and BackdropFilter to CanvasKit backend (flut…

bc86713

…ter/engine#13768)

engine-flutter-autoroll mentioned this pull request Nov 12, 2019

Roll engine 31cd2dfca22a..270fa824e46b (25 commits) flutter/flutter#44755

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2019

63e8c62 Add ImageFilter and BackdropFilter to CanvasKit backend (flut…

dbd4663

…ter/engine#13768)

engine-flutter-autoroll mentioned this pull request Nov 12, 2019

Roll engine 31cd2dfca22a..270fa824e46b (25 commits) flutter/flutter#44757

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2019

63e8c62 Add ImageFilter and BackdropFilter to CanvasKit backend (flut…

b054dea

…ter/engine#13768)

engine-flutter-autoroll mentioned this pull request Nov 12, 2019

Roll engine 31cd2dfca22a..270fa824e46b (25 commits) flutter/flutter#44759

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2019

63e8c62 Add ImageFilter and BackdropFilter to CanvasKit backend (flut…

6184ee8

…ter/engine#13768)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2019

63e8c62 Add ImageFilter and BackdropFilter to CanvasKit backend (flut…

9884200

…ter/engine#13768)

This was referenced Nov 12, 2019

Roll engine 31cd2dfca22a..270fa824e46b (25 commits) flutter/flutter#44762

Closed

Roll engine 31cd2dfca22a..270fa824e46b (25 commits) flutter/flutter#44768

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2019

63e8c62 Add ImageFilter and BackdropFilter to CanvasKit backend (flut…

7c9c002

…ter/engine#13768)

engine-flutter-autoroll mentioned this pull request Nov 12, 2019

Roll engine 31cd2dfca22a..270fa824e46b (25 commits) flutter/flutter#44771

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2019

63e8c62 Add ImageFilter and BackdropFilter to CanvasKit backend (flut…

14f20fb

…ter/engine#13768)

engine-flutter-autoroll mentioned this pull request Nov 13, 2019

Roll engine 31cd2dfca22a..270fa824e46b (25 commits) flutter/flutter#44777

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 13, 2019

63e8c62 Add ImageFilter and BackdropFilter to CanvasKit backend (flut…

f5d03a7

…ter/engine#13768)

engine-flutter-autoroll mentioned this pull request Nov 13, 2019

Roll engine 31cd2dfca22a..429e56e97427 (29 commits) flutter/flutter#44781

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 13, 2019

63e8c62 Add ImageFilter and BackdropFilter to CanvasKit backend (flut…

63e1b65

…ter/engine#13768)

engine-flutter-autoroll mentioned this pull request Nov 13, 2019

Roll engine 31cd2dfca22a..429e56e97427 (29 commits) flutter/flutter#44784

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 13, 2019

63e8c62 Add ImageFilter and BackdropFilter to CanvasKit backend (flut…

a536a44

…ter/engine#13768)

GaryQian mentioned this pull request Nov 13, 2019

Roll engine manual 31cd2dfca22a...b358dc58fbce (39 commits) flutter/flutter#44790

Merged

engine-flutter-autoroll mentioned this pull request Nov 13, 2019

Roll engine 31cd2dfca22a..198c2a7ddc2b (36 commits) flutter/flutter#44832

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 13, 2019

63e8c62 Add ImageFilter and BackdropFilter to CanvasKit backend (flut…

a2c876a

…ter/engine#13768)

engine-flutter-autoroll mentioned this pull request Nov 13, 2019

Roll engine 31cd2dfca22a..198c2a7ddc2b (36 commits) flutter/flutter#44835

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 13, 2019

63e8c62 Add ImageFilter and BackdropFilter to CanvasKit backend (flut…

652da21

…ter/engine#13768)

engine-flutter-autoroll mentioned this pull request Nov 13, 2019

Roll engine 31cd2dfca22a..198c2a7ddc2b (36 commits) flutter/flutter#44837

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 13, 2019

63e8c62 Add ImageFilter and BackdropFilter to CanvasKit backend (flut…

ca4d153

…ter/engine#13768)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 13, 2019

63e8c62 Add ImageFilter and BackdropFilter to CanvasKit backend (flut…

048a5e9

…ter/engine#13768)

This was referenced Nov 13, 2019

Roll engine 31cd2dfca22a..198c2a7ddc2b (36 commits) flutter/flutter#44838

Closed

Roll engine 31cd2dfca22a..b358dc58fbce (39 commits) flutter/flutter#44839

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 13, 2019

63e8c62 Add ImageFilter and BackdropFilter to CanvasKit backend (flut…

8c37137

…ter/engine#13768)

flar mentioned this pull request Aug 28, 2020

[web] pushImageFilter not implemented flutter/flutter#47163

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add ImageFilter and BackdropFilter to CanvasKit backend #13768

Add ImageFilter and BackdropFilter to CanvasKit backend #13768

harryterkelsen commented Nov 9, 2019

nturgut Nov 9, 2019

harryterkelsen Nov 12, 2019

nturgut Nov 9, 2019

harryterkelsen Nov 12, 2019

nturgut Nov 9, 2019

harryterkelsen Nov 12, 2019

nturgut left a comment

yjbanov Nov 9, 2019

harryterkelsen Nov 12, 2019

yjbanov Nov 9, 2019

harryterkelsen Nov 12, 2019

yjbanov Nov 12, 2019

Add ImageFilter and BackdropFilter to CanvasKit backend #13768

Add ImageFilter and BackdropFilter to CanvasKit backend #13768

Conversation

harryterkelsen commented Nov 9, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nturgut left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment