Use Metal on iOS by default. #17431
Merged
Use Metal on iOS by default. #17431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes flutter/flutter#18208. All Metal for iOS related work items described in https://github.com/orgs/flutter/projects/5 have been completed.
dnfield
reviewed
Mar 31, 2020
Comment on lines
-18
to
-21
| bool ShouldUseSoftwareRenderer() { | ||
| return [[[NSProcessInfo processInfo] arguments] containsObject:@"--force-software"]; | ||
| } | ||
|
|
There was a problem hiding this comment.
This was only added recently so I could check all three variants in one build. There is no reason to support software rendering on iOS.
There was a problem hiding this comment.
So it's set somewhere else for simulator?
There was a problem hiding this comment.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 1, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 1, 2020
goderbauer
pushed a commit
to goderbauer/engine
that referenced
this pull request
Apr 16, 2020
Fixes flutter/flutter#18208. All Metal for iOS related work items described in https://github.com/orgs/flutter/projects/5 have been completed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#18208. All Metal for iOS related work items described in https://github.com/orgs/flutter/projects/5 have been completed.